[TT-1806] add required chain.link labels to k8s soak test #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofel
force-pushed
the
tt-1806-add-chainlink-k8s-labels
branch
from
dd4587d to
d73d36d
Compare
* Add required methods * Add GetBlocks * Add GetBlocks method
|
Farber98
approved these changes
Dec 6, 2024
krebernisak
approved these changes
Dec 6, 2024
| @@ -384,10 +384,24 @@ func BuildNodeContractPairID(node *client.ChainlinkClient, ocr2Addr string) (str | |||
| } | |||
|
|
|||
| func (c *Common) Default(t *testing.T, namespacePrefix string) (*Common, error) { | |||
| productName := "data-feedsv2.0" | |||
There was a problem hiding this comment.
Is this the right product name?
There was a problem hiding this comment.
it's OCRv2 test => "data-feedsv2.0", it doesn't matter whether it's running on Solana or Ethereum or some other chain.
aalu1418
approved these changes
Dec 6, 2024
Comment on lines
+388
to
+393
| nsLabels, err := environment.GetRequiredChainLinkNamespaceLabels(productName, "soak") | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| workloadPodLabels, err := environment.GetRequiredChainLinkWorkloadAndPodLabels(productName, "soak") |
There was a problem hiding this comment.
do we need to differentiate between soak vs smoke?
There was a problem hiding this comment.
I think in this case these tests are always soak, no?
chainchad
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
To better track k8s expenses