Skip to content

Commit

Permalink
removes pseudo code from handler
Browse files Browse the repository at this point in the history
  • Loading branch information
MStreet3 committed Nov 21, 2024
1 parent 8cb02ba commit 1374ce8
Showing 1 changed file with 1 addition and 18 deletions.
19 changes: 1 addition & 18 deletions core/services/workflows/syncer/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,25 +138,8 @@ func (h *eventHandler) Handle(ctx context.Context, event WorkflowRegistryEvent)
// TODO: Implement this method
func (h *eventHandler) workflowRegisteredEvent(
_ context.Context,
event WorkflowRegistryEvent,
_ WorkflowRegistryEvent,
) error {
payload, ok := event.Data.(WorkflowRegistryWorkflowRegisteredV1)
if !ok {
return fmt.Errorf("invalid data type %T for event", event.Data)
}

_ = payload

// Pre-check: verify that the workflowID matches; if it doesn’t abort and log an error via Beholder.

// Download the contents of binaryURL, configURL and secretsURL and cache them locally.

// Create a new entry in the workflow_spec table corresponding for the new workflow, with the contents of the binaryURL + configURL in the table

// If status == active, start a new WorkflowEngine instance, and add it to local map of instances.

// Spin off task to refresh the secretsURL periodically.

return ErrNotImplemented
}

Expand Down

0 comments on commit 1374ce8

Please sign in to comment.