Skip to content

Commit

Permalink
improve string
Browse files Browse the repository at this point in the history
  • Loading branch information
infiloop2 committed Sep 20, 2023
1 parent 570c4a0 commit 40c0410
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -244,9 +244,8 @@ func (r *EvmRegistry) checkUpkeeps(ctx context.Context, payloads []ocr2keepers.U
if req.Error != nil {
latestBlock := r.bs.latestBlock.Load()
checkBlock, _, _ := r.getBlockAndUpkeepId(payloads[index].UpkeepID, payloads[index].Trigger)
// primitive way of checking errors
errString := req.Error.Error()
// Exploratory: remove reliance on custom error string checks
// Exploratory: remove reliance on primitive way of checking errors
if (strings.Contains(errString, "header not found") || strings.Contains(errString, "missing trie node")) && int64(latestBlock.Number)-checkBlock.Int64() > checkBlockTooOldRange {
// Check block not found in RPC and it is too old, non-retryable error
r.lggr.Warnf("header not found error encountered in check result for upkeepId %s, check block %d, latest block %d: %s", results[index].UpkeepID.String(), checkBlock.Int64(), int64(latestBlock.Number), req.Error)
Expand Down

0 comments on commit 40c0410

Please sign in to comment.