[Functions] Fix bug in comparing subscriptions (#12379) (#12576)

Co-authored-by: Sneha Agnihotri <180277+snehaagni@users.noreply.github.com>
smartcontractkit · Mar 27, 2024 · 47eb373 · 47eb373
1 parent 61d0f28
commit 47eb373
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/core/services/gateway/handlers/functions/subscriptions/user_subscriptions.go b/core/services/gateway/handlers/functions/subscriptions/user_subscriptions.go
@@ -2,6 +2,7 @@ package subscriptions
 
 import (
 	"math/big"
+	"reflect"
 
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/pkg/errors"
@@ -54,7 +55,7 @@ func (us *userSubscriptions) UpdateSubscription(subscriptionId uint64, subscript
 	}
 
 	// there is no change to the subscription
-	if us.userSubscriptionsMap[subscription.Owner][subscriptionId] == subscription {
+	if reflect.DeepEqual(us.userSubscriptionsMap[subscription.Owner][subscriptionId], subscription) {
 		return false
 	}
 

diff --git a/core/services/gateway/handlers/functions/subscriptions/user_subscriptions_test.go b/core/services/gateway/handlers/functions/subscriptions/user_subscriptions_test.go
@@ -135,15 +135,16 @@ func TestUserSubscriptions_UpdateSubscription(t *testing.T) {
 
 	t.Run("no actual changes", func(t *testing.T) {
 		us := subscriptions.NewUserSubscriptions()
-		subscription := &functions_router.IFunctionsSubscriptionsSubscription{
+		subscription := functions_router.IFunctionsSubscriptionsSubscription{
 			Owner:          utils.RandomAddress(),
 			Balance:        big.NewInt(25),
 			BlockedBalance: big.NewInt(25),
 		}
-		updated := us.UpdateSubscription(5, subscription)
+		identicalSubscription := subscription
+		updated := us.UpdateSubscription(5, &subscription)
 		assert.True(t, updated)
 
-		updated = us.UpdateSubscription(5, subscription)
+		updated = us.UpdateSubscription(5, &identicalSubscription)
 		assert.False(t, updated)
 	})
 }