[fix] Use correct format for GH run URL (#11246)

smartcontractkit · Nov 9, 2023 · b811f00 · b811f00
1 parent 0128650
commit b811f00
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/tools/flakeytests/utils.go b/tools/flakeytests/utils.go
@@ -42,7 +42,7 @@ func getGithubMetadata(repo string, eventName string, sha string, e io.Reader, r
 		log.Fatalf("Error unmarshaling gh event at path")
 	}
 
-	runURL := fmt.Sprintf("%s/actions/%s", repo, runID)
+	runURL := fmt.Sprintf("github.com/%s/actions/runs/%s", repo, runID)
 	basicCtx := &Context{Repository: repo, CommitSHA: sha, Type: eventName, RunURL: runURL}
 	switch eventName {
 	case "pull_request":

diff --git a/tools/flakeytests/utils_test.go b/tools/flakeytests/utils_test.go
@@ -37,12 +37,13 @@ var prEventTemplate = `
 
 func TestGetGithubMetadata(t *testing.T) {
 	repo, eventName, sha, event, runID := "chainlink", "merge_group", "a-sha", `{}`, "1234"
+	expectedRunURL := fmt.Sprintf("github.com/%s/actions/runs/%s", repo, runID)
 	ctx := getGithubMetadata(repo, eventName, sha, strings.NewReader(event), runID)
-	assert.Equal(t, Context{Repository: repo, CommitSHA: sha, Type: eventName, RunURL: fmt.Sprintf("%s/actions/%s", repo, runID)}, ctx)
+	assert.Equal(t, Context{Repository: repo, CommitSHA: sha, Type: eventName, RunURL: expectedRunURL}, ctx)
 
 	anotherSha, eventName, url := "another-sha", "pull_request", "a-url"
 	event = fmt.Sprintf(prEventTemplate, anotherSha, url)
 	sha = "302eb05d592132309b264e316f443f1ceb81b6c3"
 	ctx = getGithubMetadata(repo, eventName, sha, strings.NewReader(event), runID)
-	assert.Equal(t, Context{Repository: repo, CommitSHA: anotherSha, Type: eventName, PullRequestURL: url, RunURL: fmt.Sprintf("%s/actions/%s", repo, runID)}, ctx)
+	assert.Equal(t, Context{Repository: repo, CommitSHA: anotherSha, Type: eventName, PullRequestURL: url, RunURL: expectedRunURL}, ctx)
 }