-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CCIP-4359 fee quoter supports interface for keystone (#15448)
* fix: enforce supports interface from IReceiver.sol and impliment in FeeQuoter.sol * fix: enforce supports interface from IReceiver.sol and impliment in FeeQuoter.sol * Update gethwrappers * CCIP-4359 changeset + minor fixes and wrappers * snapshot update * [Bot] Update changeset file with jira issues * lint fix * chore: import arrangement and additional comments * fix : comment in IReceiver * fix : comment in KeystoneFeedsPermissionHandler * fmt * add fee_quoter_interface * add fee_quoter_interface * remove incorrectly added mock interface * add mock interface * add fee_quoter_interface.go * added test with Keystone Forwarder * update cod cov ignore for ccip * cleanup: removed newline * update coverage * Revert "update cod cov ignore for ccip" This reverts commit 4a62610. * update lcov_prine to exclude keystone contract in coverage for CCIP * Revert "update lcov_prine to exclude keystone contract in coverage for CCIP" This reverts commit 5a0d650. * remove keystone test setup dependency * chore: update test name according to style guide * update snapshot * Revert "Revert "update lcov_prine to exclude keystone contract in coverage for CCIP"" This reverts commit 2c86461. --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
- Loading branch information
1 parent
22c6cf7
commit c1ee7ab
Showing
15 changed files
with
344 additions
and
208 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
'@chainlink/contracts': minor | ||
--- | ||
|
||
#internal Add supportsInterface to FeeQuoter for Keystone | ||
|
||
PR issue: CCIP-4359 | ||
|
||
Solidity Review issue: CCIP-3966 |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
contracts/src/v0.8/ccip/test/feeQuoter/FeeQuoter.supportsInterface.t.sol
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// SPDX-License-Identifier: BUSL-1.1 | ||
pragma solidity 0.8.24; | ||
|
||
import {IReceiver} from "../../../keystone/interfaces/IReceiver.sol"; | ||
import {ITypeAndVersion} from "../../../shared/interfaces/ITypeAndVersion.sol"; | ||
|
||
import {IERC165} from "../../../vendor/openzeppelin-solidity/v5.0.2/contracts/interfaces/IERC165.sol"; | ||
import {IFeeQuoter} from "../../interfaces/IFeeQuoter.sol"; | ||
import {FeeQuoterSetup} from "./FeeQuoterSetup.t.sol"; | ||
|
||
contract FeeQuoter_supportsInterface is FeeQuoterSetup { | ||
function test_SupportsInterface_Success() public view { | ||
assertTrue(s_feeQuoter.supportsInterface(type(IReceiver).interfaceId)); | ||
assertTrue(s_feeQuoter.supportsInterface(type(ITypeAndVersion).interfaceId)); | ||
assertTrue(s_feeQuoter.supportsInterface(type(IFeeQuoter).interfaceId)); | ||
assertTrue(s_feeQuoter.supportsInterface(type(IERC165).interfaceId)); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.