Completes tests comparing capability registry views

deployment/common/changeset/capability_registry.go

@@ -43,12 +43,6 @@ func HydrateCapabilityRegistry(v v1_0.CapabilityRegistryView, env deployment.Env
 	}
 
 	nopsParams := v.NopsToNopsParams()
-	for _, nop := range v.Nops {
-		nopsParams = append(nopsParams, capabilities_registry.CapabilitiesRegistryNodeOperator{
-			Admin: nop.Admin,
-			Name:  nop.Name,
-		})
-	}
 	tx, err := deployedContract.Contract.AddNodeOperators(chain.DeployerKey, nopsParams)
 	if _, err = deployment.ConfirmIfNoError(chain, tx, keystone.DecodeErr(capabilities_registry.CapabilitiesRegistryABI, err)); err != nil {
 		return nil, fmt.Errorf("failed to add node operators: %w", err)

deployment/common/changeset/capability_registry_test.go

@@ -5,12 +5,14 @@ import (
 	"os"
 	"testing"
 
-	chainsel "github.com/smartcontractkit/chain-selectors"
 	"github.com/stretchr/testify/require"
 	"go.uber.org/zap/zapcore"
 
+	chainsel "github.com/smartcontractkit/chain-selectors"
+
 	"github.com/smartcontractkit/chainlink/deployment/common/view/v1_0"
 	"github.com/smartcontractkit/chainlink/deployment/environment/memory"
+	"github.com/smartcontractkit/chainlink/v2/core/gethwrappers/keystone/generated/capabilities_registry"
 	"github.com/smartcontractkit/chainlink/v2/core/logger"
 )
 
@@ -31,4 +33,23 @@ func TestHydrateCapabilityRegistry(t *testing.T) {
 	hydrated, err := HydrateCapabilityRegistry(capabilityRegistryView, env, cfg)
 	require.NoError(t, err)
 	require.NotNil(t, hydrated)
+
+	chainSelector, err := chainsel.SelectorFromChainId(chainID)
+	require.NoError(t, err)
+	chain, ok := env.Chains[chainSelector]
+	require.True(t, ok)
+	capabilityRegistry, err := capabilities_registry.NewCapabilitiesRegistry(hydrated.Address, chain.Client)
+	require.NoError(t, err)
+	require.NotNil(t, capabilityRegistry)
+	capView, err := v1_0.GenerateCapabilityRegistryView(capabilityRegistry)
+	require.NoError(t, err)
+
+	// Setting address/owner values to be the same in order to compare the views
+	capView.Address = capabilityRegistryView.Address
+	capView.Owner = capabilityRegistryView.Owner
+	b1, err := capabilityRegistryView.MarshalJSON()
+	require.NoError(t, err)
+	b2, err := capView.MarshalJSON()
+	require.NoError(t, err)
+	require.Equal(t, string(b1), string(b2))
 }