Skip to content

Commit

Permalink
moving step error metric out of isFullyProcessed (#15071)
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickhuie19 authored Nov 1, 2024
1 parent 4e49641 commit e6817ea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/services/workflows/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,7 @@ func (e *Engine) handleStepUpdate(ctx context.Context, stepUpdate store.Workflow
l.Info("workflow finished")
case store.StatusErrored:
l.Info("execution errored")
e.metrics.incrementTotalWorkflowStepErrorsCounter(ctx)
case store.StatusCompletedEarlyExit:
l.Info("execution terminated early")
// NOTE: even though this marks the workflow as completed, any branches of the DAG
Expand Down Expand Up @@ -985,7 +986,6 @@ func (e *Engine) isWorkflowFullyProcessed(ctx context.Context, state store.Workf
}
}
}
e.metrics.incrementTotalWorkflowStepErrorsCounter(ctx)
}
return nil
})
Expand Down

0 comments on commit e6817ea

Please sign in to comment.