[auto 2.5.1] Fix automation - mercury v0.3 response decoding #10806
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6318842664 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6325346384 |
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6326223838 |
| @@ -506,6 +506,7 @@ func (r *EvmRegistry) multiFeedsRequest(ctx context.Context, ch chan<- MercuryDa | |||
| } else if resp.StatusCode == 420 { | |||
| // in 0.3, this will happen when missing/malformed query args, missing or bad required headers, non-existent feeds, or no permissions for feeds | |||
| retryable = false | |||
| state = encoding.InvalidMercuryRequest | |||
There was a problem hiding this comment.
this is unrelated to the bug but was missing before (different bug)
infiloop2
changed the title
|
Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6327524519 |
infiloop2
changed the title
infiloop2
changed the title
|
I think this is a good example of where making the streams lookup code more modular would be a significant benefit. IIUC, these changes now have to be c/p'd to monitoring and to the debugging script. IMHO it would be a more efficient use of dev time and safer if we could export a single streamslookup module from core and import that in chaincli and monitoring - it would help keep everything in sync. |
|
SonarQube Quality Gate
|
Fully agree! Just needs time to refactor and properly test |
No description provided.