fix build-test-image action #11225
Merged
fix build-test-image action #11225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudhwarrier
requested review from
chainchad,
javuto,
jkongie,
jmank88 and
samsondav
as code owners
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
SonarQube Quality Gate
|
jmank88
reviewed
Nov 8, 2023
| @@ -55,7 +55,7 @@ runs: | |||
| file: ./integration-tests/test.Dockerfile | |||
| build-args: | | |||
| BASE_IMAGE=${{ inputs.QA_AWS_ACCOUNT_NUMBER }}.dkr.ecr.${{ inputs.QA_AWS_REGION }}.amazonaws.com/test-base-image | |||
| IMAGE_VERSION=${{ steps.version.output.version }} | |||
| IMAGE_VERSION=${{ steps.version.outputs.version }} | |||
There was a problem hiding this comment.
What were the effects of this problem? Have we been testing incorrect versions this whole time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.