Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functions] Coordinator v1.1 changes #11269

Merged
merged 3 commits into from
Nov 13, 2023
Merged

[Functions] Coordinator v1.1 changes #11269

merged 3 commits into from
Nov 13, 2023

Conversation

justinkaseman
Copy link
Contributor

@justinkaseman justinkaseman commented Nov 13, 2023 •
edited
Loading

Small changes:

  • Gas: one line for report decoding
  • Gas: keep ReportInvalid error string under 32 bytes
  • Move ChainSpecificUtil to libraries folder

Credit to @RensR

@justinkaseman justinkaseman requested a review from a team as a code owner November 13, 2023 18:59
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@justinkaseman justinkaseman requested a review from RensR November 13, 2023 19:00
bolekk
bolekk approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@bolekk bolekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@justinkaseman justinkaseman added this pull request to the merge queue Nov 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2023
@justinkaseman justinkaseman added this pull request to the merge queue Nov 13, 2023
Merged via the queue into develop with commit 023985b Nov 13, 2023
99 checks passed
@justinkaseman justinkaseman deleted the FUN-1095 branch November 13, 2023 20:09
@snehaagni snehaagni mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolekk bolekk bolekk approved these changes

@RensR RensR Awaiting requested review from RensR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinkaseman @bolekk @RensR