plugins/cmd/chainlink-median: move to chainlink-feeds #11270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
force-pushed
the
chainlink-feeds
branch
from
26ad2de to
5f49586
Compare
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
changed the title
patrickhuie19
previously approved these changes
Nov 13, 2023
vyzaldysanchez
previously approved these changes
Nov 14, 2023
jmank88
dismissed stale reviews from vyzaldysanchez and patrickhuie19
via
6d64392
jmank88
force-pushed
the
chainlink-feeds
branch
3 times, most recently
from
e4fc5ce to
8dc9b60
Compare
jmank88
force-pushed
the
chainlink-feeds
branch
2 times, most recently
from
30b5d2a to
528a84a
Compare
vyzaldysanchez
previously approved these changes
Nov 27, 2023
| @@ -1,6 +1,6 @@ | |||
| module github.com/smartcontractkit/chainlink/core/scripts | |||
|
|
|||
| go 1.21 | |||
| go 1.21.3 | |||
There was a problem hiding this comment.
/nit do we want to use 1.21.4?
Line 1 in bd7e233
There was a problem hiding this comment.
I upgraded and this didn't change. I think it is propagated from a dependency as a minimal version perhaps? 🤷
patrickhuie19
previously approved these changes
Nov 28, 2023
jmank88
dismissed stale reviews from patrickhuie19 and vyzaldysanchez
via
fc27ca5
jmank88
force-pushed
the
chainlink-feeds
branch
from
528a84a to
fc27ca5
Compare
jmank88
force-pushed
the
chainlink-feeds
branch
2 times, most recently
from
a6e08ad to
6b5c36d
Compare
jmank88
force-pushed
the
chainlink-feeds
branch
from
6b5c36d to
66bd553
Compare
|
SonarQube Quality Gate
|
samsondav
approved these changes
Nov 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fbac
pushed a commit
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCF-2733
Requires: