Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a unit test to cover 2 check results #11490

Merged
merged 1 commit into from
Dec 14, 2023
Merged

add a unit test to cover 2 check results #11490

merged 1 commit into from
Dec 14, 2023

Conversation

shileiwill
Copy link
Contributor

@shileiwill shileiwill commented Dec 5, 2023 •
edited
Loading

AUTO-8090

In this PR, we add a unit test to cover 2 check results, one does mercury, and the other doesnt. we ensure the output order is correct.

Test plan:

  • unit test, existing tests and the new added unit test should pass
  • smoke test should all pass

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

I see that you haven't updated any README files. Would it make sense to do so?

@shileiwill shileiwill force-pushed the AUTO-8087-modular-streams branch 2 times, most recently from 498d1f9 to 948a5bd Compare December 5, 2023 17:57
@shileiwill shileiwill force-pushed the AUTO-8090-remove-index branch from 52dc30e to 3522a21 Compare December 5, 2023 18:04
@shileiwill shileiwill marked this pull request as ready for review December 5, 2023 18:04
@shileiwill shileiwill requested review from a team, RyanRHall and infiloop2 December 5, 2023 18:04
infiloop2
infiloop2 previously approved these changes Dec 8, 2023
View reviewed changes
@shileiwill shileiwill force-pushed the AUTO-8087-modular-streams branch from 948a5bd to 92a84ef Compare December 8, 2023 19:26
@shileiwill shileiwill requested a review from a team as a December 8, 2023 19:26
@shileiwill shileiwill force-pushed the AUTO-8087-modular-streams branch 6 times, most recently from 274c2f5 to b17456b Compare December 13, 2023 00:11
Base automatically changed from AUTO-8087-modular-streams to develop December 13, 2023 20:29
@shileiwill shileiwill dismissed infiloop2’s stale review December 13, 2023 20:29

The base branch was changed.

@shileiwill shileiwill marked this pull request as draft December 13, 2023 23:48
@shileiwill shileiwill force-pushed the AUTO-8090-remove-index branch from 3522a21 to dc048d2 Compare December 13, 2023 23:58
@shileiwill shileiwill marked this pull request as ready for review December 13, 2023 23:58
@shileiwill shileiwill requested a review from a team December 13, 2023 23:59
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@infiloop2 infiloop2 added this pull request to the merge queue Dec 14, 2023
Merged via the queue into develop with commit 71e1a79 Dec 14, 2023
80 of 81 checks passed
@infiloop2 infiloop2 deleted the AUTO-8090-remove-index branch December 14, 2023 11:35
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infiloop2 infiloop2 infiloop2 approved these changes

@RyanRHall RyanRHall Awaiting requested review from RyanRHall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shileiwill @infiloop2