Remove failure reasons and states from mercury and use encoding #11523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
shileiwill
force-pushed
the
AUTO-8161-remove-duplication
branch
from
9f32d83 to
9a347dd
Compare
shileiwill
force-pushed
the
AUTO-7928-mercury-refactoring
branch
8 times, most recently
from
cc4947a to
f0dc63f
Compare
shileiwill
force-pushed
the
AUTO-8161-remove-duplication
branch
2 times, most recently
from
14ceb5e to
7b9a760
Compare
infiloop2
reviewed
Dec 15, 2023
| @@ -149,7 +149,7 @@ func (p *abiPacker) DecodeStreamsLookupRequest(data []byte) (*StreamsLookupError | |||
| }, nil | |||
| } | |||
|
|
|||
| func (p *abiPacker) UnpackCheckCallbackResult(callbackResp []byte) (uint8, bool, []byte, uint8, *big.Int, error) { | |||
| func (p *abiPacker) UnpackCheckCallbackResult(callbackResp []byte) (encoding.PipelineExecutionState, bool, []byte, uint8, *big.Int, error) { | |||
There was a problem hiding this comment.
other uint8 can be converted back to failure reason
infiloop2
reviewed
Dec 15, 2023
| @@ -1,17 +0,0 @@ | |||
| package mercury | |||
|
|
|||
| type MercuryUpkeepFailureReason uint8 | |||
infiloop2
reviewed
Dec 15, 2023
| @@ -1,16 +0,0 @@ | |||
| package mercury | |||
|
|
|||
| type MercuryUpkeepState uint8 | |||
shileiwill
force-pushed
the
AUTO-8161-remove-duplication
branch
2 times, most recently
from
8f0708e to
daed5a1
Compare
shileiwill
force-pushed
the
AUTO-8161-remove-duplication
branch
from
daed5a1 to
307d52d
Compare
|
SonarQube Quality Gate
|
infiloop2
approved these changes
Dec 18, 2023
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTO-8161
Have failure reasons and pipeline states in a centralized place, in encoding package. Remove the states and failure reasons in mercury package.
Change back the Strong type, get rid of uint8.
Test Plan:
No logic change, all unit tests, smoke tests should pass.
I didnt add new tests, let me know if new coverage needed.