Add onRamps support to LinkMon #11571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fbac
commented
Dec 14, 2023
fbac
commented
- Add support for CCIP onRamps.
- Add support for CL Automation to trigger the contract.
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
fbac
force-pushed
the
linkmon-onramps
branch
4 times, most recently
from
e8a5ecb to
9db14ad
Compare
fbac
force-pushed
the
linkmon-onramps
branch
from
9db14ad to
5a95989
Compare
RyanRHall
suggested changes
Dec 18, 2023
contracts/src/v0.8/automation/upkeeps/LinkAvailableBalanceMonitor.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/automation/upkeeps/LinkAvailableBalanceMonitor.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/automation/upkeeps/LinkAvailableBalanceMonitor.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/automation/upkeeps/LinkAvailableBalanceMonitor.sol
Outdated
Show resolved
Hide resolved
fbac
force-pushed
the
linkmon-onramps
branch
from
e06af05 to
9cfa798
Compare
fbac
force-pushed
the
linkmon-onramps
branch
from
2d8cb78 to
fde3af6
Compare
fbac
force-pushed
the
linkmon-onramps
branch
3 times, most recently
from
63b1660 to
8bfb4dc
Compare
fbac
force-pushed
the
linkmon-onramps
branch
from
8bfb4dc to
794906d
Compare
RyanRHall
suggested changes
Jan 9, 2024
contracts/src/v0.8/automation/upkeeps/LinkAvailableBalanceMonitor.sol
Outdated
Show resolved
Hide resolved
| address[] private s_watchList; | ||
|
|
||
| /// @notice s_watchList contains all the addresses watched by this monitor | ||
| /// It mainly provides the length() function |
There was a problem hiding this comment.
this you can preface with an @dev comment
There was a problem hiding this comment.
sorry, poor communication on my part. I meant like this!
/// @notice s_watchList contains all the addresses watched by this monitor
/// @dev It mainly provides the length() functionI think in general, it's nice to give all comments an appropriate natspec heading
contracts/src/v0.8/automation/upkeeps/LinkAvailableBalanceMonitor.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/automation/upkeeps/LinkAvailableBalanceMonitor.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/automation/upkeeps/LinkAvailableBalanceMonitor.sol
Outdated
Show resolved
Hide resolved
RyanRHall
suggested changes
Jan 10, 2024
| address[] private s_watchList; | ||
|
|
||
| /// @notice s_watchList contains all the addresses watched by this monitor | ||
| /// It mainly provides the length() function |
There was a problem hiding this comment.
sorry, poor communication on my part. I meant like this!
/// @notice s_watchList contains all the addresses watched by this monitor
/// @dev It mainly provides the length() functionI think in general, it's nice to give all comments an appropriate natspec heading
RyanRHall
approved these changes
Jan 10, 2024
|
SonarQube Quality Gate
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.