[FUN-877] Persist subscriptions fetched from contracts #11573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts
branch
2 times, most recently
from
a8d4add to
8718c46
Compare
bolekk
reviewed
Dec 14, 2023
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts
branch
2 times, most recently
from
8613b6b to
2b4c9fb
Compare
bolekk
reviewed
Dec 19, 2023
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts
branch
4 times, most recently
from
2ab33de to
d26839a
Compare
agparadiso
changed the title
agparadiso
requested review from
a team,
samsondav and
jmank88
as code owners
bolekk
requested changes
Dec 21, 2023
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts
branch
2 times, most recently
from
4380e1b to
05a16d1
Compare
agparadiso
commented
Dec 21, 2023
Comment on lines
208
to
215
| err = s.orm.UpsertSubscription(CachedSubscription{ | ||
| SubscriptionID: subscriptionId, | ||
| RouterContractAddress: s.router.Address(), | ||
| IFunctionsSubscriptionsSubscription: subscription, | ||
| }) | ||
| if err != nil { | ||
| s.lggr.Errorf("unexpected error updating subscription in the cache: %w", err) | ||
| } |
There was a problem hiding this comment.
💭 We can persist this async if we think this might become a bottleneck
There was a problem hiding this comment.
Can we call Upsert only when the value changed? That would save us a lot of unnecessary DB calls.
There was a problem hiding this comment.
changed the subscription implementation to return a true when an actual update was performed, now it should only update the db when a value changes.
bolekk
requested changes
Dec 22, 2023
Comment on lines
208
to
215
| err = s.orm.UpsertSubscription(CachedSubscription{ | ||
| SubscriptionID: subscriptionId, | ||
| RouterContractAddress: s.router.Address(), | ||
| IFunctionsSubscriptionsSubscription: subscription, | ||
| }) | ||
| if err != nil { | ||
| s.lggr.Errorf("unexpected error updating subscription in the cache: %w", err) | ||
| } |
There was a problem hiding this comment.
Can we call Upsert only when the value changed? That would save us a lot of unnecessary DB calls.
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts
branch
2 times, most recently
from
1825524 to
b0d79cd
Compare
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts
branch
from
b0d79cd to
3f45ccb
Compare
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts
branch
from
55ed335 to
c52163d
Compare
|
SonarQube Quality Gate
|
bolekk
approved these changes
Jan 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
agparadiso
deleted the
feature/FUN-877_persist_data_fetched_from_contracts
branch
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a cache layer that will persist the subscriptions fetched from contracts.