Move core eth utils to evm #11584
Merged
Move core eth utils to evm #11584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimriou
requested review from
a team,
jkongie,
jmank88,
samsondav,
bolekk,
justinkaseman,
KuphJr,
sdrug,
martin-cll,
connorwstein,
prashantkumar1982,
krehermann,
RyanRHall,
PiotrTrzpil and
reductionista
as code owners
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
previously approved these changes
Dec 15, 2023
amit-momin
reviewed
Dec 18, 2023
amit-momin
reviewed
Dec 18, 2023
amit-momin
reviewed
Dec 18, 2023
amit-momin
reviewed
Dec 18, 2023
core/chains/evm/utils/utils.go
Outdated
| @@ -35,3 +181,108 @@ func NewRedialBackoff() backoff.Backoff { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| // RetryWithBackoff retries the sleeper and backs off if not Done | |||
| func RetryWithBackoff(ctx context.Context, fn func() (retry bool)) { | |||
There was a problem hiding this comment.
This might be useful for common and other chains
There was a problem hiding this comment.
RetryWithBackoff uses a Backoff with arbitrary values ( Min: 1 * time.Second, Max: 10 * time.Second ) so it's better if we keep it implementation-specific
jmank88
previously approved these changes
Dec 19, 2023
|
SonarQube Quality Gate
|
jmank88
approved these changes
Dec 20, 2023
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the functions included in
core/utilsareevm-specific. They either import go-ethereum packages or they require chain-specific logic. This PR moves these methods undercore/chains/evmand improves dependency tree.