Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-758] Fixes Upgrade Test #11589

Merged
merged 5 commits into from
Dec 18, 2023
Merged

[TT-758] Fixes Upgrade Test #11589

merged 5 commits into from
Dec 18, 2023

Conversation

kalverra
Copy link
Collaborator

No description provided.

@kalverra kalverra requested a review from a team as a code owner December 15, 2023 20:39
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@kalverra kalverra enabled auto-merge December 15, 2023 20:53
@kalverra kalverra requested a review from a team as a code owner December 15, 2023 21:17
tateexon
tateexon previously approved these changes Dec 15, 2023
integration-tests/go.mod Outdated Show resolved Hide resolved
WithGeth().
WithCLNodes(1).
Build()
require.NoError(t, err)

upgradeImage, err := osutil.GetEnv("UPGRADE_IMAGE")
upgradeImage, err := osutil.GetEnv("TEST_UPGRADE_IMAGE")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why TEST ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

WithGeth().
WithCLNodes(1).
Build()
require.NoError(t, err)

upgradeImage, err := osutil.GetEnv("UPGRADE_IMAGE")
upgradeImage, err := osutil.GetEnv("TEST_UPGRADE_IMAGE")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

AnieeG
AnieeG previously approved these changes Dec 18, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalverra kalverra added this pull request to the merge queue Dec 18, 2023
Merged via the queue into develop with commit 6ce226c Dec 18, 2023
84 checks passed
@kalverra kalverra deleted the fixMigrationTest branch December 18, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants