-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-758] Fixes Upgrade Test #11589
[TT-758] Fixes Upgrade Test #11589
Conversation
I see that you haven't updated any README files. Would it make sense to do so? |
WithGeth(). | ||
WithCLNodes(1). | ||
Build() | ||
require.NoError(t, err) | ||
|
||
upgradeImage, err := osutil.GetEnv("UPGRADE_IMAGE") | ||
upgradeImage, err := osutil.GetEnv("TEST_UPGRADE_IMAGE") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why TEST ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional?
WithGeth(). | ||
WithCLNodes(1). | ||
Build() | ||
require.NoError(t, err) | ||
|
||
upgradeImage, err := osutil.GetEnv("UPGRADE_IMAGE") | ||
upgradeImage, err := osutil.GetEnv("TEST_UPGRADE_IMAGE") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional?
SonarQube Quality Gate 0 Bugs No Coverage information |
No description provided.