core/services/relay/evm/mercury/wsrpc: forward health and readiness from CacheSet #11592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
force-pushed
the
cacheset-health-ready
branch
2 times, most recently
from
78e7342 to
eb0705e
Compare
jmank88
commented
Dec 18, 2023
jmank88
force-pushed
the
cacheset-health-ready
branch
2 times, most recently
from
f51b648 to
ef5575e
Compare
jmank88
requested review from
jkongie,
samsondav,
sdrug and
martin-cll
as code owners
samsondav
previously approved these changes
Dec 19, 2023
jmank88
force-pushed
the
cacheset-health-ready
branch
from
ef5575e to
3921f85
Compare
|
SonarQube Quality Gate
|
samsondav
approved these changes
Dec 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was exploring ways to lazy-init the
Mercury.WSRPCPool, and so avoid starting when it is not necessary, when I noticed that it was not forwarding the sub-service health and readiness of theCacheSet. This is fairly minor, but notice that thecacheSettakes a read lock whenHealthReport()is called, so this may impact performance in some way. (seems like we could minimize lock time by only fetching the values, then doing the loop outside of the lock?)