Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check mercury opts nil-ness prior to svcs append #11603

Merged
merged 2 commits into from
Dec 18, 2023
Merged

check mercury opts nil-ness prior to svcs append #11603

merged 2 commits into from
Dec 18, 2023

Conversation

makramkd
Copy link
Contributor

If we append a nil MercuryOpts the application startup will panic.

@makramkd
check mercury opts nil-ness prior to svcs append
c4aa78a 
If we append a nil MercuryOpts the application startup will panic.
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@makramkd makramkd marked this pull request as ready for review December 18, 2023 16:50
@makramkd makramkd mentioned this pull request Dec 18, 2023
Merged
@makramkd makramkd requested a review from a team December 18, 2023 16:57
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition D Maintainability Rating on New Code (is worse than A)
Failed condition 21.11% Technical Debt Ratio on New Code (is greater than 4%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@makramkd makramkd enabled auto-merge December 18, 2023 17:13
@makramkd makramkd added this pull request to the merge queue Dec 18, 2023
Merged via the queue into develop with commit cfbc0b0 Dec 18, 2023
83 of 84 checks passed
@makramkd makramkd deleted the guard-mercury-opts branch December 18, 2023 17:49
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsondav samsondav samsondav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makramkd @samsondav