Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed StreamStore & Add ChannelVerifier Skeleton #11604

Conversation

Fletch153
Copy link
Collaborator

No description provided.

@Fletch153 Fletch153 requested review from samsondav and removed request for austinborn December 18, 2023 16:23
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@@ -0,0 +1,18 @@
// SPDX-License-Identifier: MIT
pragma solidity 0.8.16;
Copy link
Collaborator

@austinborn austinborn Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest leaving the Proxy pragmas more flexible (^0.8.16) since other users will need to pull these into their contracts.

Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@Fletch153 Fletch153 force-pushed the MERC-1516-v-1-0-multichain-mercury-parallel-composition-channel-verifier branch from d99ccbf to 4530fe5 Compare December 21, 2023 15:51
Copy link
Contributor

Go solidity wrappers are out-of-date, regenerate them via the make wrappers-all command

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@samsondav samsondav merged this pull request into MERC-1516-v-1-0-multichain-mercury-parallel-composition Dec 21, 2023
40 of 56 checks passed
@samsondav samsondav deleted the MERC-1516-v-1-0-multichain-mercury-parallel-composition-channel-verifier branch December 21, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants