Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-765] Moves Client Compatability Tests to Nightly Run #11610

Merged
merged 14 commits into from
Dec 20, 2023
Merged

[TT-765] Moves Client Compatability Tests to Nightly Run #11610

merged 14 commits into from
Dec 20, 2023

Conversation

kalverra
Copy link
Collaborator

@kalverra kalverra commented Dec 18, 2023 •
edited
Loading

Our compatibility tests don't need to run every PR, this moves them to every night.

@kalverra kalverra requested review from tateexon and Tofel December 18, 2023 22:55
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@kalverra kalverra marked this pull request as ready for review December 18, 2023 23:07
Tofel
Tofel requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@Tofel Tofel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I'm not mistaken we wouldn't be running all OCR/OCRv2 smoke tests on each PR with these changes and we should, like we did in the past

@kalverra
Copy link
Collaborator Author

if I'm not mistaken we wouldn't be running all OCR/OCRv2 smoke tests on each PR with these changes and we should, like we did in the past

We wouldn't be running every client combination, correct, but that's overkill for what we're checking. Similar to our live testnet integration tests, clients and our interactions with them tend to change rarely, and as long as we have a semi-frequent check, I'd argue we have plenty of coverage for this scenario. Checking every client integration for every PR is a bit overkill, and can burn through our GHA limits as well.

@kalverra kalverra requested a review from a team as a code owner December 19, 2023 21:56
@kalverra kalverra mentioned this pull request Dec 20, 2023
Merged
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kalverra kalverra enabled auto-merge December 20, 2023 19:09
@kalverra kalverra added this pull request to the merge queue Dec 20, 2023
Merged via the queue into develop with commit 9603e5e Dec 20, 2023
79 checks passed
@kalverra kalverra deleted the moveClientTests branch December 20, 2023 21:28
This was referenced Feb 22, 2024
Closed
Closed
@snehaagni snehaagni mentioned this pull request Mar 7, 2024
Closed
This was referenced Mar 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tofel Tofel Tofel approved these changes

@tateexon tateexon tateexon approved these changes

@chainchad chainchad Awaiting requested review from chainchad

@javuto javuto Awaiting requested review from javuto

@jkongie jkongie Awaiting requested review from jkongie

@jmank88 jmank88 Awaiting requested review from jmank88

@samsondav samsondav Awaiting requested review from samsondav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalverra @tateexon @Tofel