Extract core/store/models #11626
Merged
Extract core/store/models #11626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
DylanTinianov
requested review from
a team,
samsondav,
prashantkumar1982 and
jmank88
as code owners
dimriou
reviewed
Dec 20, 2023
DylanTinianov
requested review from
a team,
jkongie,
krehermann and
PiotrTrzpil
as code owners
krehermann
reviewed
Dec 21, 2023
amit-momin
previously approved these changes
Jan 4, 2024
dimriou
reviewed
Jan 5, 2024
dimriou
approved these changes
Jan 5, 2024
amit-momin
approved these changes
Jan 5, 2024
jmank88
reviewed
Jan 8, 2024
| @@ -8,7 +8,7 @@ import ( | |||
| "github.com/pelletier/go-toml/v2" | |||
| "github.com/rs/zerolog/log" | |||
|
|
|||
| "github.com/smartcontractkit/chainlink/v2/core/store/models" | |||
| commonconfig "github.com/smartcontractkit/chainlink-common/pkg/config" | |||
There was a problem hiding this comment.
Can we avoid aliasing when there is no conflict?
Suggested change
| commonconfig "github.com/smartcontractkit/chainlink-common/pkg/config" | |
| "github.com/smartcontractkit/chainlink-common/pkg/config" |
|
SonarQube Quality Gate
|
prashantkumar1982
approved these changes
Jan 10, 2024
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract core/store/models to chainlink-common
models.Durationto chainlink-commonconfig.Durationmodels.URLto chainlink-commonconfig.URL