-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FUN-877] persist data fetched from allowlist contract #11648
Merged
agparadiso
merged 25 commits into
develop
from
feature/FUN-877_persist_data_fetched_from_contracts_allowlist
Jan 24, 2024
Merged
[FUN-877] persist data fetched from allowlist contract #11648
agparadiso
merged 25 commits into
develop
from
feature/FUN-877_persist_data_fetched_from_contracts_allowlist
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see that you haven't updated any README files. Would it make sense to do so? |
Go solidity wrappers are out-of-date, regenerate them via the |
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts_allowlist
branch
from
December 21, 2023 17:48
51825c3
to
cb72f42
Compare
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts_allowlist
branch
from
January 5, 2024 17:24
cb72f42
to
2cca949
Compare
Go solidity wrappers are out-of-date, regenerate them via the |
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts_allowlist
branch
2 times, most recently
from
January 8, 2024 17:16
c00b6e5
to
24aa8f2
Compare
contracts/src/v0.8/functions/dev/v1_X/accessControl/TermsOfServiceAllowList.sol
Show resolved
Hide resolved
contracts/src/v0.8/functions/dev/v1_X/accessControl/TermsOfServiceAllowList.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/functions/dev/v1_X/accessControl/TermsOfServiceAllowList.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/functions/dev/v1_X/accessControl/TermsOfServiceAllowList.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/functions/tests/v1_X/FunctionsTermsOfServiceAllowList.t.sol
Outdated
Show resolved
Hide resolved
contracts/src/v0.8/functions/tests/v1_X/FunctionsTermsOfServiceAllowList.t.sol
Show resolved
Hide resolved
KuphJr
reviewed
Jan 10, 2024
KuphJr
reviewed
Jan 10, 2024
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts_allowlist
branch
3 times, most recently
from
January 11, 2024 13:49
5da05be
to
e9c4eff
Compare
agparadiso
force-pushed
the
feature/FUN-877_persist_data_fetched_from_contracts_allowlist
branch
from
January 24, 2024 14:28
4ee343a
to
e338964
Compare
…_contracts_allowlist
KuphJr
approved these changes
Jan 24, 2024
…_contracts_allowlist
SonarQube Quality Gate |
agparadiso
deleted the
feature/FUN-877_persist_data_fetched_from_contracts_allowlist
branch
January 24, 2024 17:27
This was referenced Feb 22, 2024
This was referenced Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This mr aims to persist data from the allowlist contract into the node's db in order to speed up the re-start of a node.
Changes implemented
Tos contract
getAllowedSendersCount()
andgetAllowedSendersInRange
to iterate in batches over the allowed sendersgetBlockedSendersCount()
andgetBlockedSendersInRange
to iterate in batches over the blocked senderss_blockedSenders
type toEnumerableSet.AddressSet
to be able to iterate.Gateway handler
DeleteAllowedSenders
method that will be invoked in order to delete from thefunctions_allowlist
table every address that has been blocked onchain.Outside of scope
We are not taking into account the methods necessary to migrate existing blocked senders. this will be taken into account in a separate pr
How was this tested
The feature has been covered by unit and integration tests + validated on DB by starting a local node.
Further testing on staging will be done after merging