BCI-2591 TXM TX Finalized State #11878
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
There was a problem hiding this comment.
This is great.
I will have to review in detail later.
One thing is, ideally we wanted to add all finalization logic to the HeadTracker/HeadReader, and then the TXM should just call the HeadReader to fetch latest finalized block, without knowing anything about finalityTags or finalityDepth.
I know that hasn't yet been built in the HeadReader, but long term that's the direction we want to get at.
There are comments from Sam on Design Doc about Finality Depth, that we first need to get alignment on too.
Perhaps lets talk more at the Offsite.
|
|
||
| finalizedBlock = big.NewInt(head.BlockNumber() - int64(finalityDepth)) | ||
| if useFinalityTag { | ||
| finalizedBlock = big.NewInt(head.BlockNumber()) |
There was a problem hiding this comment.
If the req for eth_getBlcokNumber fails, then the head variable won't hold the right finalizedBlock
There was a problem hiding this comment.
We handle the error on line 190
|
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
finalizedstate to TXM Tx and TxAttempt that signals the inclusion of the corresponding transaction into the block that is deeper than configured finality depth. If the finality tag is enabled, the block was marked as finalized.confirmedtransactions, excluded from the chain due to reorg, are rebroadcasted.GET /v2/transactions/endpoint prefersfinalizedattempts to the latest.