Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: github action bumps #11885

Merged
merged 11 commits into from
Jan 25, 2024
Merged

chore: github action bumps #11885

merged 11 commits into from
Jan 25, 2024

Conversation

erikburt
Copy link
Collaborator

Changes:

  • Bump docker/login-action to 3.0.0
  • Bump docker/metadata-action to 5.5.0
  • Bump docker/setup-qemu-action to 3.0.0
  • Bump actions/upload-artifact to 3.1.3
  • Bump actions/download-artifact to 3.0.2
  • Bump actions/setup-go to 5.0.0
  • Bump goreleaser/goreleaser-action to 5.0.0
  • Bump goto-bus-stop/setup-zig to 2.2.0
  • Bump github/codeql-action to 2.16.1

Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@erikburt erikburt force-pushed the chore/gha-version-bumps branch from f688733 to 8e8039a Compare January 24, 2024 20:53
@erikburt erikburt marked this pull request as ready for review January 24, 2024 21:22
Copy link
Collaborator

@chainchad chainchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a callout to review if everything passes in CI here (looks good!) and that each of these action bumps don't have any obvious breaking changes.

@erikburt
Copy link
Collaborator Author

LGTM. Just a callout to review if everything passes in CI here (looks good!) and that each of these action bumps don't have any obvious breaking changes.

I did check everything here's a general summary of what I gathered the diff is from the release notes of all versions between old and new:

  • docker/login-action - node20 runtime + dependency version bumps
  • docker/metadata-action - node20 runtime + dependency version bumps
  • docker/setup-qemu-action - node20 runtime + dependency version bumps + two other changes which were considered a minor update in 2.1 -> 2.2
  • actions/upload-artifact - dependency version bumps
  • actions/download-artifact - dependency version bumps
  • actions/setup-go - caching enabled by default (hasn't been a problem with other usages yet) + dependency version bumps + windows runtime fixes
  • goreleaser/goreleaser-action - node20 runtime + dependency version bumps + when using --snapshot in args for this action which it doesn't appear we are doing
  • goto-bus-stop/setup-zig - node20 runtime
  • github/codeql - node20 runtime + updated codeql language packs

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chainchad chainchad added this pull request to the merge queue Jan 25, 2024
Merged via the queue into develop with commit edb08ce Jan 25, 2024
105 checks passed
@chainchad chainchad deleted the chore/gha-version-bumps branch January 25, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants