You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can pay the nativeFee with either native (msg.value) or an ERC20 token
Paying with msg.value is a problem on chains where ETH isn't the native token. For instance, on Avalanche, because AVAX is worth several thousands of percent less than ETH,
The nativeFee amount is tightly bound to the feed. If you wanted a nativeFee amount in say, AVAX, you would require a second feed
Since Data Streams is only confirmed to be able to support 30 feeds (as of writing this), we can't affort to literally double our feed count so we can bill on both Avalanche and chains where ETH is native
Short term solution
This PR contains a variation of the FeeManager contract, "FeeManagerNoNative". In this contract, we revert when msg.value != 0. Code relating to msg.value (like returning change) has been removed as well.
This contract should only ever be deployed to chains where ETH isn't the native token
Currently this is only Avalanche, but (for example) if we deployed to Polygon later, we'd deploy this to Polygon as well since MATIC is the native token, but if we deployed to Arbitrum, we wouldn't, since ETH is native there
@ad0ll could you also generate geth wrapper for this contract and commit it in this PR (core/gethwrappers/llo-feeds/generated/fee_manager_no_native/fee_manager_no_native.go)? I will need it for E2E tests
* OCR3 delegate support
* -Move adapters
-Convert if statement to switch
* - Add adapters tests
- Pin to new version of chainlink-common
* - Pin to new version of chainlink-common
* Fix go sum
* Pin to latest version of chainlink-common
I've hardcoded the solc path for FeeManagerNoNative in this PR, but have made the compile script more generic in this one: feature/dynamic-llo-feed-solc-compile-script (#12002)
I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:
#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Short term solution