BCF-2877: support mercury loopp #11933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
krehermann
force-pushed
the
feat/mercury-loopp
branch
from
393d810 to
73f4770
Compare
krehermann
force-pushed
the
feat/mercury-loopp
branch
from
4563d8f to
8d8b6ee
Compare
krehermann
requested review from
samsondav,
jmank88,
patrickhuie19,
EasterTheBunny and
george-dorin
samsondav
previously approved these changes
Feb 9, 2024
krehermann
changed the title
krehermann
force-pushed
the
feat/mercury-loopp
branch
from
8462429 to
7001f7d
Compare
krehermann
force-pushed
the
feat/mercury-loopp
branch
from
7001f7d to
6517c1a
Compare
chudilka1
force-pushed
the
feat/mercury-loopp
branch
from
6517c1a to
8ce69d2
Compare
…he underlying API is inherently duplicated
krehermann
force-pushed
the
feat/mercury-loopp
branch
from
8ce69d2 to
5194869
Compare
|
SonarQube Quality Gate
|
jmank88
approved these changes
Feb 9, 2024
samsondav
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCF-2877
BCF-2877
This is the mercury loopp implementation. It is a companion to and depends on
This change has been tested locally by running the integration tests with and without the LOOPP enabled. The procedure is documented the README. We will add CI for both loop and non loop mode as a quick followup to this work
There is some minor refactoring to initialize the reporting plugin and mercury oracle. It's covered by a new unit test.