make billing more flexible in VRF 2.5 (#11909) #12072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make billing more flexible in VRF 2.5 - percentage based billing - flat fee denominated in native * fix linting issues * address comments and fix failing tests * run goimports * fix linting issue
* allow 0 confirmation delays in VRF; use pending block for simulation in VRF * fix script build error * fix failing automation test * fix more tests * integraiton test wip * add integration tests for pending simulation block and zero confirmation delay (only v2 plus) and add simulation block option to superscript * Update core/chains/evm/client/simulated_backend_client.go Co-authored-by: Chris Cushman <104409744+vreff@users.noreply.github.com> * use pendingContractCall instead of low-level call contract * fix eth_call_test.go * handle nil gas and gasPrice in backend test client for estimateGas --------- Co-authored-by: Ilja Pavlovs <ilja.pavlovs@gmail.com> Co-authored-by: Chris Cushman <104409744+vreff@users.noreply.github.com>
jinhoonbang
requested review from
a team,
RensR,
connorwstein,
prashantkumar1982 and
samsondav
as code owners
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jinhoonbang
removed request for
a team,
samsondav,
connorwstein,
RensR and
prashantkumar1982
|
RensR
reviewed
Feb 17, 2024
| settings: | ||
| autoInstallPeers: true | ||
| excludeLinksFromLockfile: false | ||
| lockfileVersion: 5.4 |
There was a problem hiding this comment.
Please update your pnpm and do not commit this lock file downgrade
There was a problem hiding this comment.
yes will do locally. this PR won't get merged to develop. This should not affect how this image will work on the off-chain side of things for CL nodes
kidambisrinivas
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picking 2 changes on top of 2.9