[DON'T MERGE] CCIP Repository Merge - ocr2

[asoliman92]

DO NOT MERGE THAT PR, once approved and working we need to figure out way to merge it instead of squashing. Otherwise, entire effort on preserving commits history from CCIP repo will be lost.

Next steps:

• ccip eng review
• core eng review
• figuring out strategy for merge instead of squash

[mateusz-sekara]

@asoliman92 Have you checked if it's still needed? Locally integration_tests.go and integration_legacy_test.go works for me when removed

Checking here smartcontractkit/ccip#1253

[mateusz-sekara]

Ignore that, it's needed for CLO tests I created long time ago :P (Test_CLOSpecApprovalFlow)

[jmank88]

Why does this logic live in cleanupEVM as opposed to triggering when a service is closed?

[jmank88]

We've been trying to drop this import in favor of the std lib:

Suggested change

	multiErr = multierr.Append(multiErr, err)
	multiErr = errors.Join(multiErr, err)

That can be a follow up change though.

[jmank88]

Why subtract one? Returning from here means the break on 42 was encountered, before incrementing on 45. Isn't counter accurate as-is?

[winder]

To review this we should start with the following:

1. A script/algorithm for how the files were moved to chainlink. What was the original commit on the ccip repo?
2. A script to diff the source ccip commit files and the dest chainlink files.
3. Targeted review on the diff between source and dest.

On a quick inspection it looks like about 1/3 of the files were modified during the migration:

#!/usr/bin/env bash

if [[ "$OSTYPE" == "darwin"* ]]; then
    # macOS
    SUM=md5
else
    # Assume Linux
    SUM=md5sum
fi

pushd ccip/core/services/ocr2/plugins/ccip/ > /dev/null
echo -e "ccip repo commit: \n$(git log --max-count=1 --oneline --decorate)"
find . -type f -exec $SUM {} \;  > ../files.md5
popd > /dev/null
mv ./ccip/core/services/ocr2/plugins/files.md5 ./chainlink/core/services/ocr2/plugins/files.md5
pushd ./chainlink/core/services/ocr2/plugins/ccip/ > /dev/null
echo -e "chainlink repo commit: \n$(git log --max-count=1 --oneline --decorate)"

echo ""

echo "Source files not modified:"
$SUM -c ../files.md5 2>/dev/null | grep OK | wc -l
echo "Source files modified:"
$SUM -c ../files.md5 2>/dev/null | grep -v OK | wc -l

ccip repo commit:
1da6ea640d (HEAD -> ccip-develop) Cleanup http test servers (#1163)
chainlink repo commit:
01a5830252 (HEAD -> ccip/merge-ocr2, origin/ccip/merge-ocr2) Adding mockery configuration for ccip specific code

Source files not modified:
125
Source files modified:
60

[cl-sonarqube-production]

Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
77.9% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarQube

[winder]

The following commits are identical according to the script:

ccip: git checkout 44b23a5a32
chainlink: git checkout ccip/merge-ocr2 && git checkout b851bb3e87