Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE-2859 Make jira ticket linkage obligatory in PRs with solidity changes #14054

Conversation

HenryNguyen5
Copy link
Collaborator

@HenryNguyen5 HenryNguyen5 commented Aug 6, 2024

  • Split out lib functions into their own file
  • Create issue enforcement option
  • chore: Update detect-solidity-file-changes action to detect changes in solidity source files
  • Setup solidity-jira workflow

Manual Tests / Tasks:

  • Make a solidity source file change, action should fail if there's no linked ticket
  • Make a solidity source file change, action should pass if there's a linked ticket and ticket must also exist in jira
  • Job should not run if there's no solidity file changes
  • Make this check required
  • Make sure that this action auto-passes on merge_group event
  • Check that this will not block releases, we may need to handle this as an edge case release/test skipping 2 #14072
  • Rebase out workflow deletions
  • Squash fixups

@HenryNguyen5 HenryNguyen5 changed the title RE 2859 make jira ticket linkage obligatory in p rs with solidity changes RE 2859 Make jira ticket linkage obligatory in PRs with solidity changes Aug 6, 2024
chainchad
chainchad previously approved these changes Aug 7, 2024
@HenryNguyen5 HenryNguyen5 changed the title RE 2859 Make jira ticket linkage obligatory in PRs with solidity changes RE 3859 Make jira ticket linkage obligatory in PRs with solidity changes Aug 7, 2024
@HenryNguyen5 HenryNguyen5 changed the title RE 3859 Make jira ticket linkage obligatory in PRs with solidity changes RE-3859 Make jira ticket linkage obligatory in PRs with solidity changes Aug 7, 2024
@HenryNguyen5 HenryNguyen5 changed the title RE-3859 Make jira ticket linkage obligatory in PRs with solidity changes RE-2859 Make jira ticket linkage obligatory in PRs with solidity changes Aug 7, 2024
@HenryNguyen5 HenryNguyen5 force-pushed the RE-2859-make-jira-ticket-linkage-obligatory-in-p-rs-with-solidity-changes branch from 6d9bdc1 to ccfbba0 Compare August 7, 2024 22:05
@HenryNguyen5 HenryNguyen5 changed the title RE-2859 Make jira ticket linkage obligatory in PRs with solidity changes RE-3859 Make jira ticket linkage obligatory in PRs with solidity changes Aug 7, 2024
@HenryNguyen5 HenryNguyen5 force-pushed the RE-2859-make-jira-ticket-linkage-obligatory-in-p-rs-with-solidity-changes branch from 6ca4c29 to da7550a Compare August 7, 2024 22:22
@HenryNguyen5 HenryNguyen5 changed the title RE-3859 Make jira ticket linkage obligatory in PRs with solidity changes RE-2859 Make jira ticket linkage obligatory in PRs with solidity changes Aug 7, 2024
@HenryNguyen5 HenryNguyen5 force-pushed the RE-2859-make-jira-ticket-linkage-obligatory-in-p-rs-with-solidity-changes branch from da7550a to bda3734 Compare August 7, 2024 22:25
@HenryNguyen5 HenryNguyen5 force-pushed the RE-2859-make-jira-ticket-linkage-obligatory-in-p-rs-with-solidity-changes branch from bda3734 to 38d6267 Compare August 7, 2024 22:26
@HenryNguyen5 HenryNguyen5 requested a review from chainchad August 7, 2024 22:26
@HenryNguyen5 HenryNguyen5 marked this pull request as ready for review August 7, 2024 22:27
@HenryNguyen5 HenryNguyen5 requested review from a team as code owners August 7, 2024 22:27
@HenryNguyen5 HenryNguyen5 requested a review from Tofel August 7, 2024 22:28
chainchad
chainchad previously approved these changes Aug 8, 2024
Tofel
Tofel previously approved these changes Aug 8, 2024
@HenryNguyen5 HenryNguyen5 dismissed stale reviews from Tofel and chainchad via 6bebd74 August 8, 2024 19:17
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@HenryNguyen5 HenryNguyen5 added this pull request to the merge queue Aug 8, 2024
Merged via the queue into develop with commit ebd45ce Aug 8, 2024
120 checks passed
@HenryNguyen5 HenryNguyen5 deleted the RE-2859-make-jira-ticket-linkage-obligatory-in-p-rs-with-solidity-changes branch August 8, 2024 20:18
momentmaker added a commit that referenced this pull request Aug 8, 2024
* develop:
  RE-2859 Make jira ticket linkage obligatory in PRs with solidity changes (#14054)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants