Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unhandled already seen tx error for gnosis chiado #14099

Conversation

huangzhen1997
Copy link
Contributor

@huangzhen1997 huangzhen1997 commented Aug 12, 2024

Ticket: https://smartcontract-it.atlassian.net/browse/BCI-3934

Description
Alchemy on gnosis chaidao for transactions that are already known returns “alreadyknown”, while we expect the msg to contain space. This causes MultiNode to log critical error as result is classified as “unknown”.

Acceptance Criteria
“alreadyknown” is properly classified

@huangzhen1997 huangzhen1997 requested a review from a team as a code owner August 12, 2024 17:24
@huangzhen1997 huangzhen1997 changed the title add case for gnosis fix unhandled error case for gnosis chaidao already seen tx Aug 12, 2024
@huangzhen1997 huangzhen1997 changed the title fix unhandled error case for gnosis chaidao already seen tx fix unhandled already seen tx error for gnosis chaidao Aug 12, 2024
jmank88
jmank88 previously approved these changes Aug 12, 2024
Copy link
Contributor

@amit-momin amit-momin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you just update Chiado in the title so the squashed commit has the right name?

@huangzhen1997 huangzhen1997 changed the title fix unhandled already seen tx error for gnosis chaidao fix unhandled already seen tx error for gnosis chiado Aug 12, 2024
@cl-sonarqube-production
Copy link

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Aug 13, 2024
Merged via the queue into develop with commit 1d1af81 Aug 13, 2024
114 checks passed
@prashantkumar1982 prashantkumar1982 deleted the BCI-3934/fix-Gnosis-Alreadyknown-error-treated-as-Unknown branch August 13, 2024 18:37
simsonraj added a commit to smartcontractkit/ccip that referenced this pull request Aug 20, 2024
Cherry-Pick: classify arbitrum sequencer inaccessible error as retryable
(smartcontractkit/chainlink#14100)
Cherry-Pick: fix unhandled already seen tx error for gnosis chiado
(smartcontractkit/chainlink#14099)

Requires:
“alreadyknown” is properly classified
Errors are classified to be Retryable
asoliman92 pushed a commit that referenced this pull request Aug 28, 2024
* add case for gnosis

* add changeset

* fix typo

* typo

---------

Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants