-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix unhandled already seen tx error for gnosis chiado #14099
Merged
prashantkumar1982
merged 5 commits into
develop
from
BCI-3934/fix-Gnosis-Alreadyknown-error-treated-as-Unknown
Aug 13, 2024
Merged
fix unhandled already seen tx error for gnosis chiado #14099
prashantkumar1982
merged 5 commits into
develop
from
BCI-3934/fix-Gnosis-Alreadyknown-error-treated-as-Unknown
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangzhen1997
changed the title
add case for gnosis
fix unhandled error case for gnosis chaidao already seen tx
Aug 12, 2024
huangzhen1997
changed the title
fix unhandled error case for gnosis chaidao already seen tx
fix unhandled already seen tx error for gnosis chaidao
Aug 12, 2024
amit-momin
reviewed
Aug 12, 2024
jmank88
previously approved these changes
Aug 12, 2024
amit-momin
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could you just update Chiado in the title so the squashed commit has the right name?
huangzhen1997
changed the title
fix unhandled already seen tx error for gnosis chaidao
fix unhandled already seen tx error for gnosis chiado
Aug 12, 2024
dhaidashenko
approved these changes
Aug 13, 2024
prashantkumar1982
approved these changes
Aug 13, 2024
Quality Gate passedIssues Measures |
prashantkumar1982
deleted the
BCI-3934/fix-Gnosis-Alreadyknown-error-treated-as-Unknown
branch
August 13, 2024 18:37
This was referenced Aug 15, 2024
This was referenced Aug 18, 2024
simsonraj
added a commit
to smartcontractkit/ccip
that referenced
this pull request
Aug 20, 2024
Cherry-Pick: classify arbitrum sequencer inaccessible error as retryable (smartcontractkit/chainlink#14100) Cherry-Pick: fix unhandled already seen tx error for gnosis chiado (smartcontractkit/chainlink#14099) Requires: “alreadyknown” is properly classified Errors are classified to be Retryable
This was referenced Aug 21, 2024
asoliman92
pushed a commit
that referenced
this pull request
Aug 28, 2024
* add case for gnosis * add changeset * fix typo * typo --------- Co-authored-by: Prashant Yadav <34992934+prashantkumar1982@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://smartcontract-it.atlassian.net/browse/BCI-3934
Description
Alchemy on gnosis chaidao for transactions that are already known returns “alreadyknown”, while we expect the msg to contain space. This causes MultiNode to log critical error as result is classified as “unknown”.
Acceptance Criteria
“alreadyknown” is properly classified