Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies test #14118

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Bump dependencies test #14118

merged 2 commits into from
Aug 14, 2024

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Aug 14, 2024

here we can see that it still works for modified non-test Sol files: https://github.com/smartcontractkit/chainlink/actions/runs/10389519692

here we can see that it skips Slither if only test files are modified: https://github.com/smartcontractkit/chainlink/actions/runs/10389374515

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

@Tofel Tofel force-pushed the bump-dependencies_test branch from cfc9caf to 3db3e36 Compare August 14, 2024 14:19
@Tofel Tofel changed the base branch from develop to bump-dependencies August 14, 2024 14:21
@Tofel Tofel marked this pull request as ready for review August 14, 2024 14:30
@Tofel Tofel requested review from a team as code owners August 14, 2024 14:30
@Tofel Tofel requested a review from RensR August 14, 2024 14:30
@Tofel Tofel merged commit cc89622 into bump-dependencies Aug 14, 2024
125 of 128 checks passed
@Tofel Tofel deleted the bump-dependencies_test branch August 14, 2024 14:35
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants