Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Optimism L1 Oracle to support Mantle #14160

Merged
merged 25 commits into from
Aug 22, 2024
Merged

Changed Optimism L1 Oracle to support Mantle #14160

merged 25 commits into from
Aug 22, 2024

Conversation

ma33r
Copy link
Contributor

@ma33r ma33r commented Aug 20, 2024 •
edited
Loading

What

  • Changes our existing op_l1_oracle to support the Mantle Network. Specifically, for Mantle, the tokenRatio parameter is retrieved and used to calculate a gas price
  • Closes BCI-3964

Why

  • Mantle's gas price formula is similar to that of Optimism Bedrock, but it also includes a parameter called tokenRatio. The docs detailing this can be found here

@ma33r ma33r changed the title edited op stack oracle to include tokenRatio for Mantle Changed Optimism L1 Oracle to support Mantle Aug 20, 2024
@ma33r ma33r marked this pull request as ready for review August 21, 2024 13:07
@ma33r ma33r requested review from a team as code owners August 21, 2024 13:07
amit-momin
amit-momin approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@amit-momin amit-momin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaszcl
Copy link
Collaborator

lukaszcl commented Aug 21, 2024 •
edited
Loading

@ma33r please merge develop to this branch (click "Update branch"). Otherwise the PR may be stuck in merge queue. This is due to recent CI changes made on develop.

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
10.4% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

huangzhen1997
huangzhen1997 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@huangzhen1997 huangzhen1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Aug 22, 2024
Merged via the queue into develop with commit c98feb2 Aug 22, 2024
133 of 135 checks passed
@prashantkumar1982 prashantkumar1982 deleted the bci-3964-mantle-gas-oracle branch August 22, 2024 19:50
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-momin amit-momin amit-momin approved these changes

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@huangzhen1997 huangzhen1997 huangzhen1997 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ma33r @lukaszcl @huangzhen1997 @prashantkumar1982 @amit-momin