Bci 3621/try new estimation for insufficient fund error instead of retry #14234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent-fund-error-instead-of-retry
…ent-fund-error-instead-of-retry
huangzhen1997
commented
Aug 27, 2024
dimriou
reviewed
Aug 28, 2024
amit-momin
reviewed
Aug 29, 2024
amit-momin
reviewed
Aug 29, 2024
amit-momin
reviewed
Aug 29, 2024
amit-momin
previously approved these changes
Aug 29, 2024
dimriou
reviewed
Sep 2, 2024
…ent-fund-error-instead-of-retry
dimriou
reviewed
Sep 3, 2024
…ent-fund-error-instead-of-retry
|
dimriou
approved these changes
Sep 3, 2024
amit-momin
approved these changes
Sep 3, 2024
dimriou
deleted the
BCI-3621/try-new-estimation-for-insufficient-fund-error-instead-of-retry
branch
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira BCI-3621
Description
During gas spike the TXM tried to broadcast an initial attempt with a high gas price. Given the high default limit that CCIP uses (100m) the total cost of the attempt reached a very large amount (~4ETH) which resulted in InsufficientFunds error.
Solution:
Instead of retrying with the same attempt, use tryAgainWithNewEstimation to replace the existing attempt with a new one and return. Don’t call handleInProgressTx right away and just return as we need some time for the gas spike to pass.
Acceptance Criteria
Resolve gas spike issue and backward compatible.