Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index DON ID in ConfigSet event #14241

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Index DON ID in ConfigSet event #14241

merged 6 commits into from
Aug 29, 2024

Conversation

cds95
Copy link
Contributor

@cds95 cds95 commented Aug 27, 2024

Summary

  • Make donID indexed in ConfigSet event in the CapabilitiesRegistry so that it is easier to track off chain

@cds95 cds95 requested review from a team as code owners August 27, 2024 09:21
@cds95 cds95 requested review from cedric-cordenier and removed request for a team August 27, 2024 09:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

Static analysis results are available

Hey @bolekk, you can view Slither reports in the job summary here or download them as artifact here.

Please check them before merging and make sure you have addressed all issues.

DeividasK
DeividasK previously approved these changes Aug 29, 2024
View reviewed changes
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@bolekk bolekk added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@bolekk bolekk added this pull request to the merge queue Aug 29, 2024
Merged via the queue into develop with commit 7c248e7 Aug 29, 2024
169 of 171 checks passed
@bolekk bolekk deleted the make-don-id-indexed-in-config-set-event branch August 29, 2024 16:33
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
Draft
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
Draft
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeividasK DeividasK DeividasK approved these changes

@bolekk bolekk bolekk approved these changes

@cedric-cordenier cedric-cordenier Awaiting requested review from cedric-cordenier cedric-cordenier is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cds95 @bolekk @DeividasK