[DRAFT] EVM Interface Tests optimization #14261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… filter to DB query
…-get-transaction-status-method
…-finality-check-for-the-get-transaction-status-method
…-get-transaction-status-method
…-get-transaction-status-method
…-get-transaction-status-method
… query performance
…-get-transaction-status-method
…-get-transaction-status-method
…st configs and BASE64_NETWORK_CONFIG env (#14303) * Bump ctf * fix lint * Fix test * bump
* porting ccip tooling into chainlink * make deployment test run * add missing changes * fix build error * make private * more updates * changes * make lint happy * make lint happy * Use tests.WaitTimeout for CCIPReader e2e tests (#1382) We've noticed that this tests have failed a few times on the CI. I've run the tests with `go test ./... -count 100 -failfast` and it never failed locally. I assume it runs slow in CI that's why we have some failing cases, I am replacing `10s` with `tests.WaitTimeout(t)`. * core/capabilities/ccip: fix oracle startup logic (#1348) Ticket: https://smartcontract-it.atlassian.net/browse/CCIP-3078 We can't start bootstrap oracles and plugin oracles on the same chainlink node. The main reason for this is that we have a singleton `SingletonPeerWrapper` object which manages all libocr peers for the application as a whole. Since this singleton only works with a single peer ID, it creates a single OCR peer, and all streams are created using this OCR peer. Since streams must have unique config digests for the same peer object, running a bootstrap oracle and a plugin oracle for the same config digest will fail because the stream will not be created. In order to remedy this we match what will be the case in production, which is: * Separate bootstrap node, with a peer ID that is either part of the OCR committee or not (most likely the latter, in order to avoid exporting / importing the P2P key from one node's DB to another). This bootstrap node will have to have a DNS name and be publicly accessible over the internet in order to be accessed by all nodes in the committee, at least initially, to facilitate peer discovery. * Plugin node that is more locked down, i.e no public DNS name required. To enable this, in this PR we: * Tweak the `launcher` component to launch bootstrap nodes only or plugin nodes only, and not both. This does NOT rely on the on-chain bootstrap P2P IDs that are set in the OCR config. This field will be removed in subsequent PRs. * Tweak the `OracleCreator` interface to support the above operation Follow ups: * Remove the `bootstrapP2PIds` field from the OCR config in CCIPConfig.sol * Add changeset --------- Co-authored-by: dimitris <dimitrios.kouveris@smartcontract.com> Co-authored-by: Makram <makramkd@users.noreply.github.com> Co-authored-by: asoliman <abdelrahman.soliman@smartcontract.com> Co-authored-by: Abdelrahman Soliman (Boda) <2677789+asoliman92@users.noreply.github.com>
silaslenihan
force-pushed
the
cw-evm-interface-tests
branch
from
3af8173 to
f1fbbe5
Compare
|
silaslenihan
force-pushed
the
cw-evm-interface-tests
branch
5 times, most recently
from
46b89ea to
1467436
Compare
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Dependencies
Resolves Dependencies