Keystone in CRIB #14326

HenryNguyen5 · 2024-09-04T01:17:37Z

This PR enables keystone in CRIB. In summary, it:

Deploys 2 nodesets, of 5 nodes each
The first nodeset is used to setup a streams trigger DON
The second nodeset is used to setup a workflow DON, with the OCR3 capability and write trigger being local capabilities
The setup includes a workflow that is successfully executed: https://github.com/smartcontractkit/chainlink/pull/14326/files#diff-1d84a52709e4a92e7693dbb5ea24606c6a1d8f28990890bb97bbdcc81852b0beR70

Note that a good portion of this code will be replaced with work done at chainlink/deployments. It's better IMO to get this merged in sooner rather than later to begin integration work with chainlink/deployments ASAP to avoid continuing duplicate implementations of the same provisioning logic.

TODO:

Set mod refs back to their original versions via make gomodslocalupdate
Update chainlink aptos to reflect new repo ref

github-actions · 2024-10-17T06:42:19Z

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

core/services/relay/evm/mercury/transmitter.go

HenryNguyen5 · 2024-10-30T22:35:31Z

core/scripts/common/helpers.go

-	PanicErr(err)
-
-	jsonRPCClient, err := rpc.Dial(ethURL)
+	insecureSkipVerify := os.Getenv("INSECURE_SKIP_VERIFY") == "true"


Needed to add this since CRIB can run locally via kind, which uses https but a locally generated cert

HenryNguyen5 · 2024-10-30T22:36:12Z

core/scripts/keystone/main.go

-		src.NewDeployJobSpecsCommand(),
-		src.NewGenerateCribClusterOverridesCommand(),
-		src.NewDeleteJobsCommand(),
+		src.NewProvisionKeystoneCommand(),


For reviewers: This is the main entrypoint, CRIB scripts call into this command only to provision everything. All other commands below are essentially subcmds of this one

HenryNguyen5 · 2024-10-30T22:37:08Z

core/scripts/keystone/main.go

+		src.NewPreprovisionCribCommand(),
+		src.NewPostprovisionCribCommand(),
+		src.NewProvisionCapabilitesRegistryCommand(),
+		src.NewProvisionStreamsTriggerCommand(),
 		src.NewDeployAndInitializeCapabilitiesRegistryCommand(),


@cedric-cordenier Can we remove this? I kept it around because I wasnt sure if the team needs this. NewProvisionCapabilitesRegistryCommand handles provisioning CR for crib

Yes we can remove this if NewProvisionCapabilitesRegistryCommand handles it.

core/scripts/keystone/main.go

HenryNguyen5 · 2024-10-30T22:37:42Z

core/scripts/keystone/src/01_provision_keystone.go

+	return "provision-keystone"
+}
+
+func (g *provisionKeystone) Run(args []string) {


For reviewers: This is the main entrypoint to keystone in CRIB

core/scripts/keystone/src/02_deploy_keystone_workflows.go

cl-sonarqube-production · 2024-10-30T23:36:19Z

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

core/scripts/go.mod

tools/goreleaser-config/go.mod

jmank88 · 2024-12-20T18:55:44Z

tools/goreleaser-config/go.mod

@@ -1,6 +1,6 @@
 module github.com/smartcontractkit/chainlink/tools/goreleaser-config

-go 1.23.0
+go 1.22.8


Is this intentional?

i want to say yes, but i do not remember the reasoning behind it now :/. I could try setting it back and seeing it it breaks any tooling

jmank88 · 2024-12-20T18:57:20Z

core/scripts/keystone/src/99_files.go

+}
+
+func ensureArtefactsDir(artefactsDir string) {
+	_, err := os.Stat(artefactsDir)
 	if err != nil {


Should this be checking for a certain kind of error? https://pkg.go.dev/os#IsNotExist

jmank88 · 2024-12-20T18:59:35Z

core/scripts/keystone/src/01_toolkit_test.go

+	"github.com/stretchr/testify/assert"
+)
+
+func TestMustReadNodesList(t *testing.T) {


Suggested change

func TestMustReadNodesList(t *testing.T) {

func Test_mustReadNodesList(t *testing.T) {

… into CRIB-322-keystone-evm-contract-deployment-tooling

krehermann

This looks good to me

Main request: A README about how to use the tools so that I can push it forward next year

minimal cmds to start, run, stop
cfg or permission required to use it
known limitations

and anything keystone specific that isn't covered in normal crib implementations

justinkaseman

This looks good to me

Main request: A README about how to use the tools so that I can push it forward next year

minimal cmds to start, run, stop
cfg or permission required to use it
known limitations
and anything keystone specific that isn't covered in normal crib implementations

I'll pair with Henry early next week to take notes / record a video on this

PR LGTM at a glance, approving to get out of rebase hell, with further usage next week.

…-tooling

chainchad · 2025-01-10T16:08:23Z

Notes from call: in the future, will need to chainlink/deployments integrated to this.

…-tooling

cl-sonarqube-production · 2025-01-10T21:47:28Z

Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

HenryNguyen5 changed the title ~~CRIB 322 keystone evm contract deployment tooling~~ KIAB Streams Trigger Provisioner Sep 4, 2024

HenryNguyen5 force-pushed the CRIB-322-keystone-evm-contract-deployment-tooling branch 3 times, most recently from eaad372 to 7abd46d Compare September 18, 2024 23:59

HenryNguyen5 mentioned this pull request Sep 19, 2024

CRIB 438 add update bridge chainlink cli command #14503

Closed

HenryNguyen5 force-pushed the CRIB-322-keystone-evm-contract-deployment-tooling branch from 6537149 to f0b0226 Compare September 25, 2024 23:00

HenryNguyen5 force-pushed the CRIB-322-keystone-evm-contract-deployment-tooling branch 2 times, most recently from 3a10b2a to 7dfbe68 Compare October 17, 2024 06:21

HenryNguyen5 force-pushed the CRIB-322-keystone-evm-contract-deployment-tooling branch 2 times, most recently from 357886c to 9864099 Compare October 25, 2024 16:28

HenryNguyen5 force-pushed the CRIB-322-keystone-evm-contract-deployment-tooling branch from 7f49528 to b658c21 Compare October 30, 2024 22:33

HenryNguyen5 marked this pull request as ready for review October 30, 2024 22:33

HenryNguyen5 requested review from a team as code owners October 30, 2024 22:33

HenryNguyen5 requested a review from cedric-cordenier October 30, 2024 22:33

HenryNguyen5 commented Oct 30, 2024

View reviewed changes

HenryNguyen5 changed the title ~~KIAB Streams Trigger Provisioner~~ Keystone in CRIB Oct 30, 2024

krehermann previously approved these changes Oct 31, 2024

View reviewed changes

HenryNguyen5 dismissed krehermann’s stale review via e262cf7 November 1, 2024 02:55

HenryNguyen5 requested a review from archseer November 1, 2024 03:02

jmank88 reviewed Nov 1, 2024

View reviewed changes

core/scripts/go.mod Outdated Show resolved Hide resolved

jmank88 reviewed Nov 1, 2024

View reviewed changes

tools/goreleaser-config/go.mod Show resolved Hide resolved

HenryNguyen5 added 3 commits November 7, 2024 16:52

Add node api wrapper for ergonomic cmd usage

48f5f91

Add streams trigger template

11f32e9

Add mock external adapter for v03 mercury

80523fe

jmank88 reviewed Dec 20, 2024

View reviewed changes

HenryNguyen5 added 2 commits December 20, 2024 11:03

Merge branch 'develop' of https://github.com/smartcontractkit/chainlink…

a35f536

… into CRIB-322-keystone-evm-contract-deployment-tooling

Bump wrappers to 1.1.0

2b0a459

krehermann reviewed Dec 20, 2024

View reviewed changes

justinkaseman self-requested a review December 20, 2024 22:37

justinkaseman previously approved these changes Dec 20, 2024

View reviewed changes

Merge branch 'develop' into CRIB-322-keystone-evm-contract-deployment…

1d2f212

…-tooling

justinkaseman dismissed their stale review via 1d2f212 December 26, 2024 19:46

justinkaseman requested a review from a team as a code owner December 26, 2024 19:46

krehermann added 2 commits January 6, 2025 10:45

Merge branch 'develop' into CRIB-322-keystone-evm-contract-deployment…

ddfc1f3

…-tooling

fix test indentation, quoting

8bbd762

krehermann added 3 commits January 10, 2025 14:11

revert bad merge to main; workflow.go, cap_encoder*

0db7346

Merge branch 'develop' into CRIB-322-keystone-evm-contract-deployment…

74860f6

…-tooling

linter

a7c47ed

justinkaseman self-requested a review January 10, 2025 21:55

justinkaseman approved these changes Jan 10, 2025

View reviewed changes

krehermann enabled auto-merge January 10, 2025 21:58

krehermann approved these changes Jan 10, 2025

View reviewed changes

krehermann added this pull request to the merge queue Jan 10, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2025

krehermann added this pull request to the merge queue Jan 10, 2025

Merged via the queue into develop with commit adf13dc Jan 10, 2025
173 of 175 checks passed

krehermann deleted the CRIB-322-keystone-evm-contract-deployment-tooling branch January 10, 2025 23:08

github-actions bot mentioned this pull request Jan 10, 2025

[DO NOT MERGE] Changeset Release Preview - v2.20.0 #13148

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Keystone in CRIB #14326

Keystone in CRIB #14326

HenryNguyen5 commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

HenryNguyen5 Oct 30, 2024

HenryNguyen5 Oct 30, 2024

HenryNguyen5 Oct 30, 2024

justinkaseman Dec 20, 2024

HenryNguyen5 Oct 30, 2024

cl-sonarqube-production bot commented Oct 30, 2024

jmank88 Dec 20, 2024

HenryNguyen5 Dec 20, 2024 •

edited

Loading

jmank88 Dec 20, 2024

jmank88 Dec 20, 2024

krehermann left a comment •

edited

Loading

justinkaseman left a comment •

edited

Loading

chainchad commented Jan 10, 2025

cl-sonarqube-production bot commented Jan 10, 2025

	func TestMustReadNodesList(t *testing.T) {
	func Test_mustReadNodesList(t *testing.T) {

Keystone in CRIB #14326

Keystone in CRIB #14326

Conversation

HenryNguyen5 commented Sep 4, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

AER Report: CI Core ran successfully ✅

AER Report: Operator UI CI ran successfully ✅

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cl-sonarqube-production bot commented Oct 30, 2024

Quality Gate failed

Choose a reason for hiding this comment

HenryNguyen5 Dec 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krehermann left a comment • edited Loading

Choose a reason for hiding this comment

justinkaseman left a comment • edited Loading

Choose a reason for hiding this comment

chainchad commented Jan 10, 2025

cl-sonarqube-production bot commented Jan 10, 2025

Quality Gate passed

HenryNguyen5 commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

HenryNguyen5 Dec 20, 2024 •

edited

Loading

krehermann left a comment •

edited

Loading

justinkaseman left a comment •

edited

Loading