WS URL can be optional when LogBroadcaster is disabled #14364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangzhen1997
requested review from
reductionista and
dhaidashenko
and removed request for
a team
jmank88
requested changes
Sep 9, 2024
dhaidashenko
requested changes
Sep 9, 2024
core/chains/evm/client/evm_client.go
Outdated
| @@ -20,7 +20,7 @@ func NewEvmClient(cfg evmconfig.NodePool, chainCfg commonclient.ChainConfig, cli | |||
| var sendonlys []commonclient.SendOnlyNode[*big.Int, RPCClient] | |||
| largePayloadRPCTimeout, defaultRPCTimeout := getRPCTimeouts(chainType) | |||
| for i, node := range nodes { | |||
| if node.SendOnly != nil && *node.SendOnly { | |||
| if node.WSURL == nil || (node.SendOnly != nil && *node.SendOnly) { | |||
There was a problem hiding this comment.
A secondary or SendOnly node has limited functionality. It's only used to broadcast transactions (fire and forget), and we are not running health checks for it.
We should not change the type of the node. Instead, introduce changes to the RPC client.
There was a problem hiding this comment.
Moving the enforcement check to Dial() at rpc_client.go
dhaidashenko
reviewed
Sep 9, 2024
…BCFR-451/make-ws-url-optional
jmank88
previously approved these changes
Sep 27, 2024
|
dhaidashenko
approved these changes
Oct 3, 2024
jmank88
approved these changes
Oct 3, 2024
DylanTinianov
approved these changes
Oct 3, 2024
This was referenced Oct 3, 2024
matYang
pushed a commit
to smartcontractkit/ccip
that referenced
this pull request
Nov 14, 2024
Optional WS URL for RPCs to unblock new chain integration. Charry-picks from: smartcontractkit/chainlink#14354 smartcontractkit/chainlink#14373 smartcontractkit/chainlink#14534 smartcontractkit/chainlink#14364 smartcontractkit/chainlink#14929 --------- Co-authored-by: Joe Huang <joe.huang@smartcontract.com>
matYang
added a commit
to smartcontractkit/ccip
that referenced
this pull request
Nov 18, 2024
Optional WS URL for RPCs to unblock new chain integration. Charry-picks from: smartcontractkit/chainlink#14534 smartcontractkit/chainlink#14364 smartcontractkit/chainlink#14929 --------- Co-authored-by: Joe Huang <joe.huang@smartcontract.com> Co-authored-by: Adam Hamrick <adam.hamrick@smartcontract.com> Co-authored-by: Chunkai Yang <matYang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WS URL can be optional (empty string) when LogBroadcaster is disabled. If WS URL was not provided, SubscribeFilterLogs should fail with an explicit error
Tickets:
BCFR-451