Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint: --fix nolintlint issues #14957

Merged
merged 1 commit into from
Dec 3, 2024
Merged

golangci-lint: --fix nolintlint issues #14957

merged 1 commit into from
Dec 3, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Oct 25, 2024

No description provided.

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Oct 25, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/llo, ubuntu-latest) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/relay/evm, ubuntu-latest) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/codec, ubuntu-latest) , Flakeguard Root Project / Run Tests (github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/mercury/v1/reportcode... , Flakeguard Deployment Project / Run Tests (github.com/smartcontractkit/chainlink/deployment/environment/clo, ubuntu-latest) , Flakeguard Deployment Project / Report , Flakeguard Root Project / Report , Flakey Test Detection , SonarQube Scan

1. Error mapping test results to owners: no such file or directory:[Flakeguard Root Project / Report]

Source of Error:
Set combined test results	2024-12-02T19:15:24.0979836Z 2024/12/02 19:15:24 Error mapping test results to owners: open .github/CODEOWNERS: no such file or directory
Set combined test results	2024-12-02T19:15:24.0996205Z ##[error]Process completed with exit code 1.

Why: The error occurred because the script attempted to open the .github/CODEOWNERS file, which does not exist in the repository. This file is required to map test results to code owners.

Suggested fix: Ensure that the .github/CODEOWNERS file exists in the repository. If it does not, create it with the appropriate content to map code owners to the respective paths.

2. Error mapping test results to paths: no such file or directory:[Flakeguard Deployment Project / Report]

Source of Error:
Set combined test results	2024-12-02T19:13:31.2133541Z 2024/12/02 19:13:31 Error mapping test results to paths: lstat deployment: no such file or directory
Set combined test results	2024-12-02T19:13:31.2150966Z ##[error]Process completed with exit code 1.

Why: The error occurred because the script attempted to access the deployment directory, which does not exist. This directory is required to map test results to specific paths.

Suggested fix: Ensure that the deployment directory exists in the repository. If it does not, create it or update the script to point to the correct directory.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@jmank88 jmank88 force-pushed the nolintlint-fix branch 9 times, most recently from f53b903 to 0dbe680 Compare October 29, 2024 13:55
@jmank88 jmank88 force-pushed the nolintlint-fix branch 6 times, most recently from 7aeee52 to d258fb4 Compare November 20, 2024 14:49
if p := path.Base(strings.TrimPrefix(filepath, prefix)); len(p) < len(filepath) {
//nolint:errcheck
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only flagged for missing an explanation, but it was suppressing real errors too.

@jmank88 jmank88 force-pushed the nolintlint-fix branch 3 times, most recently from eaaaca8 to 3040282 Compare November 20, 2024 22:52
@jmank88 jmank88 marked this pull request as ready for review November 21, 2024 00:01
@jmank88 jmank88 requested review from a team as code owners November 21, 2024 00:01
patrickhuie19
patrickhuie19 previously approved these changes Nov 26, 2024
Farber98
Farber98 previously approved these changes Nov 26, 2024
vyzaldysanchez
vyzaldysanchez previously approved these changes Nov 26, 2024
EasterTheBunny
EasterTheBunny previously approved these changes Nov 26, 2024
@jmank88
Copy link
Contributor Author

jmank88 commented Dec 2, 2024

Rebased

@jmank88 jmank88 added this pull request to the merge queue Dec 3, 2024
Merged via the queue into develop with commit 9f869fa Dec 3, 2024
179 of 183 checks passed
@jmank88 jmank88 deleted the nolintlint-fix branch December 3, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.