-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAPPL-222] feat(workflows): adds a secrets syncer for workflow registry #15114
Conversation
Flaky Test Detector for
|
7f71bf9
to
a3f4ceb
Compare
|
||
import "container/heap" | ||
|
||
type Heap interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future style note: it's best to abstract as late as possible and to avoid altogether if possible; in this case you have exactly one implementation of the heap (blockHeighHeap), so you could have avoided declaring these at all (I think anyway -- I'm not sure I follow why publicHeap is necessary).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't expect the public thing to come into it at all on reflection: this is an internal implementation detail of the syncer, so shouldn't be exposed publicly. I may well be missing something though.
Flaky Test Detector for
|
903f65d
to
cd0b041
Compare
The base branch was changed.
CAPPL-222
See the design doc here.
This PR:
indexed
modifier from the WorkflowRegistry'sWorkflowRegistryRequestedForceUpdateSecretsV1
eventworkflow_secrets
DB table andORM
interface for interacting with itRequires
#14990
Supports