Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAPPL-222] feat(workflows): adds a secrets syncer for workflow registry #15114

Closed
wants to merge 61 commits into from

Conversation

MStreet3
Copy link
Contributor

@MStreet3 MStreet3 commented Nov 5, 2024

CAPPL-222

See the design doc here.

This PR:

  • implements a secrets sync in the workflow registry syncer
  • removes indexed modifier from the WorkflowRegistry's WorkflowRegistryRequestedForceUpdateSecretsV1 event
  • adds a workflow_secrets DB table and ORM interface for interacting with it
  • functional test against a simulated EVM backend in EVM relays

Requires

#14990

Supports

@MStreet3 MStreet3 requested review from a team as code owners November 5, 2024 05:09
Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between workflow-registry-contract-draft and c4ada2e (cappl-2222/secrets-syncer).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 45 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                                                     TestName            PassRatio  RunCount   Skipped
---------                                                                                       ---------           ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/capabilities/workflows/syncer  Test_SecretsWorker  0%         1          false

@eutopian eutopian force-pushed the workflow-registry-contract-draft branch from 7f71bf9 to a3f4ceb Compare November 13, 2024 18:11

import "container/heap"

type Heap interface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future style note: it's best to abstract as late as possible and to avoid altogether if possible; in this case you have exactly one implementation of the heap (blockHeighHeap), so you could have avoided declaring these at all (I think anyway -- I'm not sure I follow why publicHeap is necessary).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't expect the public thing to come into it at all on reflection: this is an internal implementation detail of the syncer, so shouldn't be exposed publicly. I may well be missing something though.

Copy link
Contributor

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between workflow-registry-contract-draft and ac9040d (cappl-2222/secrets-syncer).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 55 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                              TestName                               PassRatio  RunCount   Skipped
---------                                                                ---------                              ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer  Test_Handler                           0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer  Test_Handler/fails_to_get_secrets_url  0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer  Test_Handler/fails_to_update_secrets   0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer  Test_Handler/success                   0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/workflows/syncer  Test_Handler/fails_to_fetch_contents   0%         1          false

@eutopian eutopian force-pushed the workflow-registry-contract-draft branch 8 times, most recently from 903f65d to cd0b041 Compare November 15, 2024 17:43
Base automatically changed from workflow-registry-contract-draft to develop November 16, 2024 01:21
@eutopian eutopian dismissed cedric-cordenier’s stale review November 16, 2024 01:21

The base branch was changed.

@MStreet3 MStreet3 requested review from a team as code owners November 17, 2024 22:45
@MStreet3 MStreet3 closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants