Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCIP-4130 CCIP-Compatible Generic BurnMintERC20 #15123

Merged
merged 56 commits into from
Nov 21, 2024
Merged

CCIP-4130 CCIP-Compatible Generic BurnMintERC20 #15123

merged 56 commits into from
Nov 21, 2024

Conversation

jhweintraub
Copy link
Collaborator

@jhweintraub jhweintraub commented Nov 5, 2024 •
edited
Loading

Generic BurnMintERC20 that is compatible with CCIPGetAdmin() functionality. Includes tests which are named and organized based on newly established naming conventions for tests. BurnMintERC20 implements OZ AccessControl instead of Ownable2Step but maintains a singular ccip admin

@jhweintraub jhweintraub requested a review from a team as a code owner November 5, 2024 16:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

Static analysis results are available

Hey @jhweintraub, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited
Loading

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/hot-pandas-carry.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

@jhweintraub jhweintraub requested a review from a team as a code owner November 6, 2024 15:10
@jhweintraub jhweintraub requested review from a team as code owners November 6, 2024 17:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@jhweintraub jhweintraub requested a review from a team as a code owner November 6, 2024 23:53
@jhweintraub jhweintraub requested a review from ilija42 November 6, 2024 23:53
jhweintraub
jhweintraub commented Nov 7, 2024
View reviewed changes
core/gethwrappers/shared/go_generate.go
//go:generate go run ../generation/generate/wrap.go ../../../contracts/solc/v0.8.19/LinkToken/LinkToken.abi ../../../contracts/solc/v0.8.19/LinkToken/LinkToken.bin LinkToken link_token
//go:generate go run ../generation/generate/wrap.go ../../../contracts/solc/v0.8.19/BurnMintERC20/BurnMintERC20.abi ../../../contracts/solc/v0.8.19/BurnMintERC20/BurnMintERC20.bin BurnMintERC20 burn_mint_erc20
Copy link
Collaborator Author

@jhweintraub jhweintraub Nov 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wym? That we don't need it since we have the link_token and erc677? There's different functions which is why its included.

@RensR RensR force-pushed the feat/genericERC20 branch from 8f88a4c to 1202ea8 Compare November 13, 2024 11:31
RensR
RensR previously approved these changes Nov 13, 2024
View reviewed changes
RensR
RensR previously approved these changes Nov 18, 2024
View reviewed changes
@jhweintraub jhweintraub added this pull request to the merge queue Nov 21, 2024
Merged via the queue into develop with commit 72da397 Nov 21, 2024
187 checks passed
@jhweintraub jhweintraub deleted the feat/genericERC20 branch November 21, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RensR RensR RensR approved these changes

@matYang matYang matYang approved these changes

@winder winder Awaiting requested review from winder winder was automatically assigned from smartcontractkit/ccip-offchain

@rstout rstout Awaiting requested review from rstout rstout was automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 was automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd was automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv was automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara was automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang was automatically assigned from smartcontractkit/ccip-offchain

@ilija42 ilija42 Awaiting requested review from ilija42 ilija42 was automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhweintraub @matYang @RensR