CCIP-4165 additional e2e integration tests #15245
Conversation
jhweintraub
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xnogo
…or-tokens-transfers-tests
…or-tokens-transfers-tests
…or-tokens-transfers-tests
…or-tokens-transfers-tests
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
…or-tokens-transfers-tests
…or-tokens-transfers-tests
jhweintraub
force-pushed
the
CCIP-4165-e-2-e-tests-implement-pricing-for-tokens-transfers-tests
branch
from
d99db51 to
ad9aea9
Compare
| // The balance should be 4 since we've already sent 2 tokens over this lane direction in the | ||
| // first part of the test, so balance should already be two |
There was a problem hiding this comment.
It's better to avoid sequential testing as this will cost the execution time. I would advice to see how we can make these test runs in parallel.
Few options are like:
- Using multiple wallet address
- Creating it as individual test which has its own setup and runner to run in parallel.
There was a problem hiding this comment.
running in parallel with multiple wallets makes the most sense as the original ticket specified under the same e2e test.
| delete(expectedSeqNum, sourceDestPair) | ||
| }) | ||
|
|
||
| t.Run("Send Token Pay with native remote chain -> home", func(t *testing.T) { |
There was a problem hiding this comment.
If the difference in this test is only about fee token, then we can pass that as an argument and simplify the test.
| }}, | ||
| } | ||
|
|
||
| t.Run("Send message Pay with Link token home chain -> remote", func(t *testing.T) { |
There was a problem hiding this comment.
As our intention is to test fee token, I think we can avoid testing this is in different lanes. We can test it in the same lane with different token by that we can simplify the test more.
There was a problem hiding this comment.
The original ticket specified that each test scenario should flip the lane direction
There was a problem hiding this comment.
I feel it is not needed. @makramkd @mateusz-sekara What do you guys think about this?
| delete(expectedSeqNum, sourceDestPair) | ||
| }) | ||
|
|
||
| t.Run("Send message pay with wrapped native home chain -> remote", func(t *testing.T) { |
There was a problem hiding this comment.
We can do something like this:
- Setup one lane say home chain -> remote
- Create test input struct with fee token type (link, native and wnative) and message type (Token, Data and Token+Data)
- Loop the test and try to run in parallel using multiple wallet address.
WDYT?
…or-tokens-transfers-tests
use the fee token paid from the event rather than the call before the request is made
makramkd
deleted the
CCIP-4165-e-2-e-tests-implement-pricing-for-tokens-transfers-tests
branch
Additional End-to-End integration tests for CCIP involving token transfers paying in different feeTokens