Replace NodesFromJD with NodeInfo #15256

archseer · 2024-11-15T05:05:00Z

No description provided.

archseer · 2024-11-15T05:07:30Z

deployment/environment.go

+		return nil, nil
+	}
+	// if nodeIDs starts with `p2p_` lookup by p2p_id instead
+	filterByPeerIDs := strings.HasPrefix("p2p_", nodeIDs[0])


A bit implicit, but JD node IDs start with node_. p2p_ is a good indicator to filter by peer ID instead

github-actions · 2024-11-15T05:25:58Z

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

archseer · 2024-11-15T05:37:51Z

deployment/environment.go

@@ -278,6 +312,7 @@ func NodeInfo(nodeIDs []string, oc NodeChainConfigsLister) (Nodes, error) {
 			if err != nil {
 				return nil, err
 			}
+			// TODO: this is evm specific, make it work with aptos


still need to address this

github-actions · 2024-11-15T05:43:40Z

Flaky Test Detector for `deployment/go.mod` project has failed ❌

Ran new or updated tests between jd-improvements and dce776a (reuse-nodeinfo).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 19 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                TestName       PassRatio  RunCount   Skipped
---------                                                  ---------      ---------  ---------  ---------
github.com/smartcontractkit/chainlink/deployment/keystone  TestDeploy     0%         1          false
github.com/smartcontractkit/chainlink/deployment/keystone  TestDeployCLO  0%         1          false

github-actions · 2024-11-15T11:08:46Z

Flaky Test Detector for `deployment/go.mod` project has failed ❌

Ran new or updated tests between jd-improvements and 311b042 (reuse-nodeinfo).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 19 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                                   TestName             PassRatio  RunCount   Skipped
---------                                                                     ---------            ---------  ---------  ---------
github.com/smartcontractkit/chainlink/deployment/keystone/changeset/internal  TestUpdateDon        0%         1          false
github.com/smartcontractkit/chainlink/deployment/keystone/changeset/internal  TestUpdateDon/empty  0%         1          false
github.com/smartcontractkit/chainlink/deployment/keystone                     TestDeploy           0%         1          false
github.com/smartcontractkit/chainlink/deployment/keystone                     TestDeployCLO        0%         1          false

github-actions · 2024-11-15T13:06:09Z

Flaky Test Detector for `deployment/go.mod` project has failed ❌

Ran new or updated tests between jd-improvements and 759c3c1 (reuse-nodeinfo).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 19 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                                   TestName             PassRatio  RunCount   Skipped
---------                                                                     ---------            ---------  ---------  ---------
github.com/smartcontractkit/chainlink/deployment/keystone                     TestDeploy           0%         1          false
github.com/smartcontractkit/chainlink/deployment/keystone                     TestDeployCLO        0%         1          false
github.com/smartcontractkit/chainlink/deployment/keystone/changeset/internal  TestUpdateDon        0%         1          false
github.com/smartcontractkit/chainlink/deployment/keystone/changeset/internal  TestUpdateDon/empty  0%         1          false

github-actions · 2024-11-21T04:44:43Z

Static analysis results are available

Hey @archseer, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

github-actions · 2024-11-21T04:45:14Z

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

deployment/keystone/deploy.go

krehermann · 2024-11-22T05:08:53Z

deployment/keystone/types.go

 }

-func (d RegisteredDon) signers() []common.Address {
+func (d RegisteredDon) signers(chainFamily string) []common.Address {


would this be easier if passing the selector rather than the family? all the nodes have to have the registry chain enabled for the system to work so should be safe to pass the registry selector

add a small test would give confidence of this func

this was actually the bug: I used the registry selector but the write nodes didn't have the registry chain defined, so the lookup was failing

krehermann · 2024-11-22T05:10:05Z

deployment/keystone/types.go

+// 	accountAddress     string
+// }
+
+func toNodeKeys(o *deployment.Node, registryChainSel uint64) NodeKeys {


add a small test?

deployment/keystone/types.go

archseer commented Nov 15, 2024

View reviewed changes

archseer force-pushed the reuse-nodeinfo branch from 448d463 to dce776a Compare November 15, 2024 05:34

archseer commented Nov 15, 2024

View reviewed changes

archseer force-pushed the reuse-nodeinfo branch from 3dd311f to 759c3c1 Compare November 15, 2024 12:57

archseer force-pushed the reuse-nodeinfo branch from 759c3c1 to 3f915f4 Compare November 21, 2024 04:43

archseer changed the base branch from jd-improvements to ks/jd-view November 21, 2024 04:44

archseer force-pushed the reuse-nodeinfo branch from 308aff7 to ef1547b Compare November 21, 2024 12:26

archseer marked this pull request as ready for review November 21, 2024 12:55

archseer requested review from a team, eutopian and yevshev as code owners November 21, 2024 12:55

archseer requested a review from krehermann November 21, 2024 12:55

jmank88 reviewed Nov 21, 2024

View reviewed changes

deployment/keystone/deploy.go Outdated Show resolved Hide resolved

Base automatically changed from ks/jd-view to develop November 21, 2024 15:45

archseer requested review from a team as code owners November 21, 2024 15:45

archseer force-pushed the reuse-nodeinfo branch from ef1547b to 9557e71 Compare November 22, 2024 02:55

archseer added 3 commits November 22, 2024 11:56

Replace NodesFromJD with NodeInfo

512b156

Remove ocr2Node and use deployment.Node directly

36aa1f1

"robust" chainID handling

dec4508

archseer force-pushed the reuse-nodeinfo branch from 9557e71 to d5fbc8c Compare November 22, 2024 02:56

Fix tests

26f5904

archseer force-pushed the reuse-nodeinfo branch from d5fbc8c to 26f5904 Compare November 22, 2024 02:57

archseer enabled auto-merge November 22, 2024 02:57

krehermann previously approved these changes Nov 22, 2024

View reviewed changes

krehermann and others added 2 commits November 22, 2024 14:51

move code; add test for ocr3 config

31de9e5

Do not truncate non-EVM keys

73835e1

archseer dismissed krehermann’s stale review via a29c805 November 22, 2024 06:18

Fix key decoding in ocr3config test

39c17b8

archseer force-pushed the reuse-nodeinfo branch 2 times, most recently from 52f12d2 to c588ee2 Compare November 22, 2024 06:29

Slightly simplify

772a589

archseer force-pushed the reuse-nodeinfo branch from c588ee2 to 772a589 Compare November 22, 2024 06:35

Add a test for toNodeKeys()

d0b943f

krehermann previously approved these changes Nov 22, 2024

View reviewed changes

krehermann requested a review from jmank88 November 22, 2024 13:52

connorwstein previously approved these changes Nov 22, 2024

View reviewed changes

fix test - update offchainconfig to match value with test secrets

fc2afb9

krehermann dismissed stale reviews from connorwstein and themself via fc2afb9 November 22, 2024 16:39

krehermann approved these changes Nov 22, 2024

View reviewed changes

krehermann requested a review from connorwstein November 22, 2024 17:58

connorwstein approved these changes Nov 22, 2024

View reviewed changes

archseer added this pull request to the merge queue Nov 22, 2024

Merged via the queue into develop with commit a267825 Nov 22, 2024
150 checks passed

archseer deleted the reuse-nodeinfo branch November 22, 2024 21:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace NodesFromJD with NodeInfo #15256

Replace NodesFromJD with NodeInfo #15256

archseer commented Nov 15, 2024

archseer Nov 15, 2024

github-actions bot commented Nov 15, 2024 •

edited

Loading

archseer Nov 15, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024

krehermann Nov 22, 2024

krehermann Nov 22, 2024

archseer Nov 22, 2024

krehermann Nov 22, 2024

Replace NodesFromJD with NodeInfo #15256

Replace NodesFromJD with NodeInfo #15256

Conversation

archseer commented Nov 15, 2024

archseer Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 15, 2024 • edited Loading

AER Report: CI Core ran successfully ✅

AER Report: Operator UI CI ran successfully ✅

archseer Nov 15, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 15, 2024

Flaky Test Detector for deployment/go.mod project has failed ❌

Failed Tests

github-actions bot commented Nov 15, 2024

Flaky Test Detector for deployment/go.mod project has failed ❌

Failed Tests

github-actions bot commented Nov 15, 2024

Flaky Test Detector for deployment/go.mod project has failed ❌

Failed Tests

github-actions bot commented Nov 21, 2024

Static analysis results are available

github-actions bot commented Nov 21, 2024

krehermann Nov 22, 2024

Choose a reason for hiding this comment

krehermann Nov 22, 2024

Choose a reason for hiding this comment

archseer Nov 22, 2024

Choose a reason for hiding this comment

krehermann Nov 22, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 15, 2024 •

edited

Loading

Flaky Test Detector for `deployment/go.mod` project has failed ❌

Flaky Test Detector for `deployment/go.mod` project has failed ❌

Flaky Test Detector for `deployment/go.mod` project has failed ❌