CCIP-4014 enable rmn tests in ci #15276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnieeG
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xAustinWang
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
makramkd
previously approved these changes
Nov 16, 2024
| E2E_RMN_RAGEPROXY_VERSION: master-5208d09 | ||
| E2E_RMN_AFN2PROXY_VERSION: master-5208d09 | ||
|
|
||
| # - id: smoke/ccip_rmn_test.go:^TestRMN_NotEnoughSigners$ |
There was a problem hiding this comment.
I see a test like this in the repo, why do we comment it out?
There was a problem hiding this comment.
This is currently failing @dimkouv is working on a PR to fix this. After that we will uncomment this
| func TestRMN_TwoMessagesOnTwoLanes(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
Do we need t.Parallel() if every test is run as a separate CI job?
There was a problem hiding this comment.
Tried parallel at first did not work. can remove it
| return image | ||
| } | ||
|
|
||
| func (r *RMNConfig) GetAFNVersion() string { |
There was a problem hiding this comment.
Shouldn't we align with a new naming? I guess no one remembers what AFN was :P
There was a problem hiding this comment.
The image name is AFN2Proxy https://github.com/smartcontractkit/rmn-v2-test-infra/tree/master/docker/afn2proxy
makramkd
previously approved these changes
Nov 19, 2024
mateusz-sekara
previously approved these changes
Nov 19, 2024
mateusz-sekara
approved these changes
Nov 19, 2024
makramkd
approved these changes
Nov 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
cedric-cordenier
pushed a commit
that referenced
this pull request
Nov 20, 2024
* enable rmn tests in ci * update references * test.parallel * try with one test * fix * fix tests * comment * remove parallel * rename image * disable flakey test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports