Add WorkflowRegistry to config #15280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
force-pushed
the
CAPPL-136-add-workflow-registry-syncer-config-options
branch
from
5229d20 to
13802d1
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
cedric-cordenier
force-pushed
the
CAPPL-136-add-workflow-registry-syncer-config-options
branch
4 times, most recently
from
20d758d to
c9ad88b
Compare
cedric-cordenier
force-pushed
the
CAPPL-136-add-workflow-registry-syncer-config-options
branch
from
e11a776 to
bb53d8b
Compare
MStreet3
approved these changes
Nov 20, 2024
ettec
approved these changes
Nov 20, 2024
george-dorin
approved these changes
Nov 20, 2024
cedric-cordenier
deleted the
CAPPL-136-add-workflow-registry-syncer-config-options
branch
chudilka1
reviewed
Nov 20, 2024
| @@ -279,6 +279,11 @@ Address = '' | |||
| NetworkID = 'evm' | |||
| ChainID = '1' | |||
|
|
|||
| [Capabilities.WorkflowRegistry] | |||
| Address = '' | |||
There was a problem hiding this comment.
@cedric-cordenier, does config-full imply empty values?
There was a problem hiding this comment.
It just means that all values have been set explicitly
| ```toml | ||
| NetworkID = 'evm' # Default | ||
| ``` | ||
| NetworkID identifies the target network where the remote registry is located. |
There was a problem hiding this comment.
Could you list the other examples of the NetworkID values here as well?
| ChainID *string | ||
| } | ||
|
|
||
| func (r *WorkflowRegistry) setFrom(f *WorkflowRegistry) { |
There was a problem hiding this comment.
Would an unset or empty field invalidate the node's config on boot if the WorkflowRegistry is defined in the config but is missing a field or value?
Please reflect it (the invalid configuration) in your test data/scripts by showing what would be an invalid way of setting the config.
There was a problem hiding this comment.
No, these are optional values so they can be unset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add config options to configure the WorkflowRegistry.