Create tool to pin locally replaced modules to latest trunk commit #15290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separating it to avoid potential merge conflicts when surrounding lines change as we expect CI to update its psuedo version.
|
I see you updated files related to
|
jmank88
reviewed
Nov 18, 2024
|
TODO
|
chainchad
commented
Nov 19, 2024
tools/gomod-required-updater/internal/updater/system_operator.go
Outdated
Show resolved
Hide resolved
jmank88
reviewed
Nov 19, 2024
Tests and linting should now be ran from the ci-core workflow.
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
Co-authored-by: Jordan Krage <jmank88@gmail.com>
erikburt
previously approved these changes
Dec 6, 2024
jmank88
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Is this separate workflow necessary?
There was a problem hiding this comment.
Hm, it's pretty sparse right now. Would love to remove it. Would you suggest just throwing this as a step in ci-core.yml?
There was a problem hiding this comment.
Well the make command already installs so what effect is this build meant to have?
There was a problem hiding this comment.
The goal would be to ensure that the build doesn't break but maybe unnecessary or it gets built in another way that I'm not aware of?
There was a problem hiding this comment.
It should already be covered by the normal CI as part of the root module. I.e. there should be a line for this package in the ci core test output
There was a problem hiding this comment.
Makes sense, removed in ccf2842.
…ub.com/smartcontractkit/chainlink into re-3199/updater-root-module-go.mod-ref
jmank88
previously approved these changes
Dec 10, 2024
erikburt
approved these changes
Dec 10, 2024
jmank88
approved these changes
Dec 10, 2024
george-dorin
pushed a commit
that referenced
this pull request
Jan 13, 2025
…15290) * Add separate require line for root module. Separating it to avoid potential merge conflicts when surrounding lines change as we expect CI to update its psuedo version. * Create tool to update certain module deps to pin to latest trunk commit * Create new makefile target to use new tool to update module deps to pin * Add support for additional local module replacements * Add support for automatically updating locally replaced modules * Update make target to auto update locally replaced modules * Run go fmt * Add ci workflow * Add test for config sourcing * Add build step to CI * Make it gomods compatible and not a separate module * Remove mocked sys op * Only build during dedicated CI workflow. Tests and linting should now be ran from the ci-core workflow. * Refactor * Remove unused function * Use psuedo version from go lib * Upate pseudo-versions for local replaces to latest time/sha * Cleanup * Update bin path * Fix README * Allow custom org/repo name and apply better validation to git cmds * Address linting * Address linting 2 * Ignore gosec lint for execs * Update Make target name * Avoid merge queue for build * Rename tool * Point to new binary * Remove unused lint directive * Ran goimports -local * Cleanup and refactor * Format * Update local requires * Add more refactoring * Clarify readme * Update comment * Update README about usage and gomods * Add gomods as a dep for new target Co-authored-by: Jordan Krage <jmank88@gmail.com> * Move pre-compiled regular expressions into vars * Fix formatting * Remove remnant from refactor * Move validation of git input into config * Run `make gomodslocalupdate` * Appease linter * Remove unnecessary inline comments * Use a better name for git exec * Remove unnecessary build workflow --------- Co-authored-by: Jordan Krage <jmank88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run locally via:
make gomodslocalupdate