Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCIP-3591 USDC tests improvements #15300

Merged
merged 3 commits into from
Nov 19, 2024
Merged

CCIP-3591 USDC tests improvements #15300

merged 3 commits into from
Nov 19, 2024

Conversation

mateusz-sekara
Copy link
Collaborator

@mateusz-sekara mateusz-sekara commented Nov 19, 2024 •
edited
Loading

Requires

Supports

Description

  • Active waiting for the token balances instead of doing a single check
  • MInor refactoring with extracting common logic to separate functions
  • More test cases
    • Sending USDC together with a regular token
    • Sending multiple USDC tokens within a single msg

@mateusz-sekara mateusz-sekara requested review from a team as code owners November 19, 2024 12:09
makramkd
makramkd previously approved these changes Nov 19, 2024
View reviewed changes
@mateusz-sekara mateusz-sekara added this pull request to the merge queue Nov 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2024
@mateusz-sekara mateusz-sekara added this pull request to the merge queue Nov 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 19, 2024
@mateusz-sekara
CCIP-3591 USDC tests improvements (#15300)
f67728a 
* Extracting some helpers

* Adding one more scenario

* Adding one more scenario
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2024
@mateusz-sekara mateusz-sekara added this pull request to the merge queue Nov 19, 2024
Merged via the queue into develop with commit 5a68674 Nov 19, 2024
161 checks passed
@mateusz-sekara mateusz-sekara deleted the usdc-tcs branch November 19, 2024 14:45
cedric-cordenier pushed a commit that referenced this pull request Nov 20, 2024
@mateusz-sekara @cedric-cordenier
CCIP-3591 USDC tests improvements (#15300)
22dccc7 
* Extracting some helpers

* Adding one more scenario

* Adding one more scenario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-gopalswami b-gopalswami b-gopalswami approved these changes

@0xnogo 0xnogo 0xnogo approved these changes

@makramkd makramkd makramkd approved these changes

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mateusz-sekara @makramkd @0xnogo @b-gopalswami