-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mock adapter from environment struct #15304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-gopalswami
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xnogo
November 19, 2024 14:43
connorwstein
previously approved these changes
Nov 19, 2024
mateusz-sekara
previously approved these changes
Nov 19, 2024
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
b-gopalswami
dismissed stale reviews from mateusz-sekara and connorwstein
via
November 19, 2024 14:58
929a4aa
I see you updated files related to
|
mateusz-sekara
previously approved these changes
Nov 19, 2024
connorwstein
previously approved these changes
Nov 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 19, 2024
b-gopalswami
dismissed stale reviews from connorwstein and mateusz-sekara
via
November 20, 2024 14:26
cd7a8de
mateusz-sekara
approved these changes
Nov 20, 2024
0xAustinWang
approved these changes
Nov 20, 2024
0xnogo
approved these changes
Nov 20, 2024
connorwstein
approved these changes
Nov 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing mock adapter from Environment struct as this is more of test stuffs. As this struct *test_env.CLClusterTestEnv is exposed now, can consume mock adapter from it directly instead of adding it to Environment struct.