Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mock adapter from environment struct #15304

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Conversation

b-gopalswami
Copy link
Contributor

Removing mock adapter from Environment struct as this is more of test stuffs. As this struct *test_env.CLClusterTestEnv is exposed now, can consume mock adapter from it directly instead of adding it to Environment struct.

connorwstein
connorwstein previously approved these changes Nov 19, 2024
mateusz-sekara
mateusz-sekara previously approved these changes Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

mateusz-sekara
mateusz-sekara previously approved these changes Nov 19, 2024
connorwstein
connorwstein previously approved these changes Nov 19, 2024
@mateusz-sekara mateusz-sekara added this pull request to the merge queue Nov 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2024
@AnieeG AnieeG added this pull request to the merge queue Nov 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2024
@mateusz-sekara mateusz-sekara added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@mateusz-sekara mateusz-sekara added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit c67b180 Nov 20, 2024
166 of 167 checks passed
@mateusz-sekara mateusz-sekara deleted the move-mockadapter branch November 20, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants