CCIP-3591 USDC transfer with multi source setup #15305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-sekara
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
0xAustinWang and
0xnogo
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
mateusz-sekara
force-pushed
the
usdc-missing-tc
branch
from
c316cc4 to
eb0b32f
Compare
asoliman92
reviewed
Nov 21, 2024
| sourceChain1 := allChainSelectors[0] | ||
| sourceChain2 := allChainSelectors[1] | ||
| destChain := allChainSelectors[2] | ||
|
|
There was a problem hiding this comment.
We already have helper functions in test_helpers to take care of this boilerplate code. Please use them.
mateusz-sekara
force-pushed
the
usdc-missing-tc
branch
from
eb0b32f to
9938b6b
Compare
mateusz-sekara
force-pushed
the
usdc-missing-tc
branch
from
9938b6b to
945fc73
Compare
makramkd
previously approved these changes
Nov 22, 2024
0xnogo
approved these changes
Nov 22, 2024
makramkd
approved these changes
Nov 22, 2024
lukaszcl
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports